Skip to content

build: suppress CMake error for src/secp256k1 subdirectory #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

build: suppress CMake error for src/secp256k1 subdirectory #2799

wants to merge 1 commit into from

Conversation

CyberTailor
Copy link
Contributor

Changed in version 3.27: Compatibility with versions of CMake older than 3.5 is deprecated. Calls to cmake_minimum_required(VERSION) or cmake_policy(VERSION) that do not specify at least 3.5 as their policy version (optionally via ...) will produce a deprecation warning in CMake 3.27 and above.

@div72
Copy link
Member

div72 commented Apr 9, 2025

@CyberTailor Is the issue caused by libsecp256k1's cmake_minimum_required(VERSION 3.1)? I can bump the subtree to the newest version which requires CMake 3.16.

@CyberTailor
Copy link
Contributor Author

Yes, this would be a better solution.

@jamescowens
Copy link
Member

Yes. Let's do that.

@div72 div72 mentioned this pull request May 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CyberTailor @div72 @jamescowens