refactor: Replace investor with non-cruncher #2805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescowens
added
the
refactor
jamescowens
force-pushed
the
replace_investor_with_noncruncher
branch
2 times, most recently
from
8f09277 to
0307a3c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to replace all references to “investor” with “non‑cruncher”, ensuring consistent naming in both core and GUI components while still supporting the legacy investor alias for backward compatibility.
- Renames translation strings, error messages, and log outputs
- Updates function names, enum values, and resource file aliases
- Adjusts command-line argument definitions and settings in the UI
Reviewed Changes
Copilot reviewed 47 out of 47 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/qt/bitcoinstrings.cpp | Updated UI strings to reflect non‑cruncher mode |
| src/qt/bitcoingui.cpp | Renamed method call to use non‑cruncher mode |
| src/qt/bitcoin.qrc | Updated file aliases for non‑cruncher SVG resources |
| src/qt/CMakeLists.txt | Replaced investor pages with non‑cruncher pages |
| src/miner.cpp | Adjusted comments and mining ID calls to non‑cruncher mode |
| src/main.h | Updated CPID flag names and associated logic |
| src/init.cpp | Added and updated arguments for non‑cruncher mode |
| src/gridcoin/* | Updated researcher logic, voting, tally, and claims |
| src/Makefile.qt.include | Replaced investor UI file references with non‑cruncher ones |
Comments suppressed due to low confidence (1)
src/gridcoin/researcher.cpp:1169
- Consider revisiting the conditional in ConfiguredForNoncruncherMode to determine if both legacy (-investor) and new (-noncruncher) flags should continue to be accepted. If backward compatibility is maintained only temporarily, document the plan to deprecate the legacy flag.
if (gArgs.GetBoolArg("-noncruncher", false) || Researcher::Email() == "noncruncher" || gArgs.GetBoolArg("-investor", false) || Researcher::Email() == "investor") {
|
@jamescowens Any specific reason for not updating |
This commit eradicates all references to "investor" in file names and code (both core and GUI). Note that -investor is still allowed and is synonymous to -noncruncher for backwards compatibility purposes.
|
I didn't run the translatioin update as part of this PR. |
jamescowens
force-pushed
the
replace_investor_with_noncruncher
branch
from
18c3ec9 to
f8b35a3
Compare
|
I ran the first part of the translation update and committed it. Should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit eradicates all references to "investor" in file names and code (both core and GUI). Note that -investor is still allowed and is synonymous to -noncruncher for backwards compatibility purposes.
Closes #2103.