Skip to content

gui: Changes the connect for the beaconChanged signal on main screen #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jamescowens
Copy link
Member

beaconChanged now connects with updateResearcherStatus which should fix the non-update of the researcher status when the beacon is activated.

beaconChanged now connects with updateResearcherStatus which should
fix the non-update of the researcher status when the beacon is
activated.
@jamescowens jamescowens self-assigned this May 31, 2025
@jamescowens jamescowens added this to the Natasha milestone May 31, 2025
@jamescowens jamescowens requested a review from Copilot May 31, 2025 23:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the connection for the beaconChanged signal so that it invokes updateResearcherStatus instead of updateResearcherAlert, aiming to fix the researcher status not refreshing when the beacon is activated.

  • Changed the slot called on beaconChanged from updateResearcherAlert to updateResearcherStatus.
Comments suppressed due to low confidence (2)

src/qt/overviewpage.cpp:376

  • Consider adding a unit test to verify that updateResearcherStatus is invoked when beaconChanged is emitted to prevent future regressions.
connect(researcherModel, &ResearcherModel::beaconChanged, this, &OverviewPage::updateResearcherStatus);

src/qt/overviewpage.cpp:376

  • Replacing the beaconChanged connection from updateResearcherAlert to updateResearcherStatus removes the alert update; consider connecting beaconChanged to updateResearcherAlert as well or ensuring alert state is updated elsewhere.
connect(researcherModel, &ResearcherModel::beaconChanged, this, &OverviewPage::updateResearcherStatus);

@jamescowens jamescowens changed the title gui: This commit changes the connect for the beaconChanged signal gui: Changes the connect for the beaconChanged signal on main screen May 31, 2025
@jamescowens
Copy link
Member Author

Stupid Copilot. updateResearcherStatus calls

    updateMagnitude();
    updatePendingAccrual();
    updateResearcherAlert();

@jamescowens jamescowens merged commit 920f074 into gridcoin-community:development May 31, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant