Skip to content

fix: fix crop view displaying issue on iOS 26 #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guoyingtao
Copy link
Owner

@guoyingtao guoyingtao commented Jun 28, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Improved stability by preventing layout operations when the crop area has no valid size. This helps avoid potential errors during image cropping.

Copy link

coderabbitai bot commented Jun 28, 2025

Walkthrough

A guard statement was added in the viewDidLayoutSubviews() method of CropViewController.swift to ensure that layout initialization only proceeds if the cropView has non-zero bounds. If the bounds are zero, the method exits early, preventing further layout and transformation operations.

Changes

File(s) Change Summary
Sources/Mantis/CropViewController/CropViewController.swift Added a guard in viewDidLayoutSubviews() to skip layout logic if cropView bounds are zero.

Poem

A careful check in layout's flow,
If bounds are zero, we now say no.
No needless work, no wasted run,
Just tidy code when size is none.
A hop ahead, our crops now thrive—
With smarter views, our apps arrive! 🥕


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbe63dd and 571aa01.

📒 Files selected for processing (1)
  • Sources/Mantis/CropViewController/CropViewController.swift (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: guoyingtao
PR: guoyingtao/Mantis#462
File: Sources/Mantis/SwiftUIView/ImageCropper.swift:145-152
Timestamp: 2025-06-19T08:13:01.113Z
Learning: In the Mantis SwiftUI implementation, the user prefers to keep the CropAction enum minimal with only the .crop case active for now, rather than implementing all possible crop actions upfront.
Sources/Mantis/CropViewController/CropViewController.swift (1)
Learnt from: guoyingtao
PR: guoyingtao/Mantis#462
File: Sources/Mantis/SwiftUIView/ImageCropper.swift:145-152
Timestamp: 2025-06-19T08:13:01.113Z
Learning: In the Mantis SwiftUI implementation, the user prefers to keep the CropAction enum minimal with only the .crop case active for now, rather than implementing all possible crop actions upfront.
🔇 Additional comments (1)
Sources/Mantis/CropViewController/CropViewController.swift (1)

190-192: Good defensive programming to prevent layout issues with zero bounds.

This guard statement effectively prevents layout initialization when the cropView has invalid (zero) bounds, which is a common timing issue in iOS view lifecycle. The early return prevents potential visual glitches or incorrect layout calculations that could occur when performing operations on a view with no size.

The fix aligns well with the PR objective of resolving display issues on iOS 26, likely caused by changes in view lifecycle timing in newer iOS versions.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant