Use rowId for unique value of checkbox column #114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New features (v. 1.2.11): ------------------------- If DataTables rowId is provided, it is used by this plugin; Changed: ```` columns().checkboxes.selected(), column().checkboxes.selected() ```` Retrieves data for selected checkboxes (like the original); If the column used with this plugin is rowID, will provide ids, if not, will provide cell.data() Added functionality: ```` columns().checkboxes.ids(), column().checkboxes.ids() ```` Retrieves rowIds for selected checkboxes in columns ```` columns().checkboxes.data(), column().checkboxes.data() ```` Retrieves row.data() for selected checkboxes in columns. This feature is usefull especially when serverSide is enabled and selected row data from other pages than the current one is needed. Renamed local variabiles to reflect more accurate the content of them: cellsData to pluginIds cellData to pluginId Bug Fixes or deprecated functions removed (v. 1.2.11): ------------------------------------------------------ If FixedColumns extension is enabled, (specially when stateSave enabled) and the column used for selection is not the first one, .dt-checkboxes-select-all cloned checkbox does not have the correct checked / indeterminate property. Removed ```` dt.fixedColumns().cellIndex() ```` because is [deprecated](https://datatables.net/reference/api/fixedColumns().cellIndex()) and does not work well with FixedColumns extension
d42ohpaz
changed the title
|
Thank you for your contribution, @nikitul and @9ae8sdf76! Please allow me some some time to review the code. I am not a fan of single commits that include lots of changes in multiple places. I also disagree with some suggested changes, for example, making the checkbox column searchable. |
mpryvkin
force-pushed
the
master
branch
2 times, most recently
from
301d948 to
9e47828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @nikitul
Fixes #112