Skip to content

Backport of Fix IPv6 address handling in LAN <-> WAN join flooder into release/1.21.x #22362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

Backport of Fix IPv6 address handling in LAN <-> WAN join flooder into release/1.21.x #22362

merged 2 commits into from
Jun 2, 2025

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #22226 to be assessed for backporting due to the inclusion of the label backport/1.21.

The below text is copied from the body of the original PR.

When advertise_addr is an IPv6 address, Consul WAN federation breaks and we get a constant stream of warnings:

[WARN]  agent.server.memberlist.wan: memberlist: Failed to resolve
i-02a3c94b46768b01f.aws-eu-west-1/2a05:d018:18a3:f202:64d9:1621:ab22:df45:8302:
lookup 2a05:d018:18a3:f202:64d9:1621:ab22:df45:8302: no such host

The LAN <-> WAN join flooder creates IPv6 addresses without square brackets with fmt.Sprintf("%s:%d", addr, s.WanJoinPort), which confuses net.SplitHostPort in memberlist.resolveAddr.

Fixes #22225

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core requested a review from a team as a code owner May 28, 2025 11:37
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes May 28, 2025
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@tkren
Copy link
Contributor

tkren commented May 28, 2025

Approved license/cla with at request to https://cla.hashicorp.com/check/hashicorp/consul?pullRequest=22362

@tkren tkren mentioned this pull request May 30, 2025
Merged
@tanmay17061 tanmay17061 merged commit 1348d1d into release/1.21.x Jun 2, 2025
101 checks passed
@tanmay17061 tanmay17061 deleted the backport/tkren/fix-ipv6-address-handling-in-lan-wan-join-flooder/morally-actual-guppy branch June 2, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmay17061 tanmay17061 tanmay17061 approved these changes

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

Assignees

@tanmay17061 tanmay17061

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hc-github-team-consul-core @tkren @tanmay17061 @github-team-consul-core-pr-approver