-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix(config): Warn on invalid characters in datacenter
property leading to incompatible DNS names
#22382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📣 Hi @arnabkaycee! a backport is missing for this PR [22382] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:
|
2 similar comments
📣 Hi @arnabkaycee! a backport is missing for this PR [22382] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:
|
📣 Hi @arnabkaycee! a backport is missing for this PR [22382] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:
|
Description
Non-compliant characters lead to invalid DNS names that are incompatible with externalized PKI Certificate generation.
Testing & Reproduction steps
datacenter
property.<service-name>.service.<datacenter>.consul
PKI generation usually fails because of invalid characters in datacenter field.Links
PR Checklist