Backport of enforce validation for missing service name in registration into release/1.21.x #22387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #22381 to be assessed for backporting due to the inclusion of the label backport/1.21.
🚨
The person who merged in the original PR is:
@sreeram77
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
Adds validation to the catalog register endpoint to ensure that a service name (
Service.Service
) is provided when registering a service. This prevents registrations with empty service names, which resulted in the Services page in the Consul UI being broken.If both
Service.ID
andService.Service
are empty, the API now returns an error message.Testing & Reproduction steps
TestCatalog_Register_RejectsMissingServiceName
incatalog_endpoint_test.go
Links
PR Checklist
Overview of commits