Skip to content

Fix(aws_verifiedaccess_endpoint) load_balancer_options.port not omitted in TCP load balancer #42694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AKarbas
Copy link

@AKarbas AKarbas commented May 20, 2025

Description

The API request for a VA endpoint does not accept LoadBalancerOptions.port when LoadBalancerOptions.protocol="tcp", but it was being set (to 0), breaking creation. This PR makes the inclusion (in the request) conditional.

Relations

Closes #42654

References

Output from Acceptance Testing

TODO - WIP
seems broken... will fix later this week.

% make testacc TESTS=TestAccVerifiedAccessEndpoint PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.9 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVerifiedAccessEndpoint'  -timeout 360m -vet=off
2025/05/20 16:36:24 Initializing Terraform AWS Provider...
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	4.121s [no tests to run]
...

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. size/M Managed by automation to categorize the size of a PR. labels May 20, 2025
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load_balancer_options.port not omitted for Verified Access Endpoint with TCP mode with Load Balancer endpoint type
2 participants