fix(ec2): Fix InvalidParameterValue error for TCP load balancer endpoints in Verified Access

[oliverjfletcher]

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No

Description

• Align the field names between what AWS returns (PortRanges) and what Terraform expects (port_range).
• Prevent invalid or spurious zero‐port patches when the user hasn’t set a port.
• Improve acceptance test coverage for Verified Access Endpoint for all protocol types
• Added short/skip switch for tests added as they take 25 minutes

Relations

Closes #42654

References

• CreateVerifiedAccessEndpointLoadBalancerOptions

Output from Acceptance Testing

➜  terraform-provider-aws git:(b-verified-access-endpoint-ports) make testacc TESTARGS='-run=TestAccVerifiedAccessEndpoint_Port' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.9 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVerifiedAccessEndpoint_Port -timeout 360m -vet=off
2025/05/22 22:01:38 Initializing Terraform AWS Provider...
=== RUN   TestAccVerifiedAccessEndpoint_PortRangeTCP
=== PAUSE TestAccVerifiedAccessEndpoint_PortRangeTCP
=== RUN   TestAccVerifiedAccessEndpoint_PortTCP
=== PAUSE TestAccVerifiedAccessEndpoint_PortTCP
=== RUN   TestAccVerifiedAccessEndpoint_PortHTTPS
=== PAUSE TestAccVerifiedAccessEndpoint_PortHTTPS
=== RUN   TestAccVerifiedAccessEndpoint_PortHTTP
=== PAUSE TestAccVerifiedAccessEndpoint_PortHTTP
=== CONT  TestAccVerifiedAccessEndpoint_PortRangeTCP
=== CONT  TestAccVerifiedAccessEndpoint_PortHTTPS
=== CONT  TestAccVerifiedAccessEndpoint_PortTCP
=== CONT  TestAccVerifiedAccessEndpoint_PortHTTP
--- PASS: TestAccVerifiedAccessEndpoint_PortHTTP (1235.41s)
--- PASS: TestAccVerifiedAccessEndpoint_PortHTTPS (1399.81s)
--- PASS: TestAccVerifiedAccessEndpoint_PortTCP (1533.20s)
--- PASS: TestAccVerifiedAccessEndpoint_PortRangeTCP (1533.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        1534.471s

...

[github-actions]

Welcome @oliverjfletcher 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider repository. Thank you very much for taking the time to do so, and welcome to the community! 🎉

---

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.