Skip to content

bump default timeout for Transit Gateway Route Table Association to 15m #42738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

albus-droid
Copy link

@albus-droid albus-droid commented May 23, 2025

Description

This increases create wait timeouts for aws_ec2_transit_gateway_route_table_association from 5 minutes to 15 minutes to accommodate longer association times without failures.

Relations

Closes #42705

Output from Acceptance Testing

make testacc TESTS=TestAccTransitGateway_serial/RouteTableAssociation_basic PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.9 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccTransitGateway_serial/RouteTableAssociation_basic'  -timeout 360m -vet=off
2025/05/23 20:30:44 Initializing Terraform AWS Provider...
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/RouteTableAssociation_basic
=== PAUSE TestAccTransitGateway_serial/RouteTableAssociation_basic
=== RUN   TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== CONT  TestAccTransitGateway_serial/RouteTableAssociation_basic
=== CONT  TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
--- PASS: TestAccTransitGateway_serial (0.00s)
    --- PASS: TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic (194.28s)
    --- PASS: TestAccTransitGateway_serial/RouteTableAssociation_basic (442.19s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        442.387s

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels May 23, 2025
@albus-droid albus-droid marked this pull request as ready for review May 23, 2025 07:12
@albus-droid albus-droid requested a review from a team as a code owner May 23, 2025 07:12
Copy link

github-actions bot commented May 23, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@albus-droid albus-droid marked this pull request as draft May 23, 2025 18:52
@albus-droid albus-droid marked this pull request as ready for review May 23, 2025 18:59
@justinretzolk
Copy link
Member

Notes from triage: The linked issue requests to add configurable timeouts rather than extending the default timeout, so I'm not sure the PR in its current state would satisfy that request.

@albus-droid
Copy link
Author

albus-droid commented May 27, 2025

Notes from triage: The linked issue requests to add configurable timeouts rather than extending the default timeout, so I'm not sure the PR in its current state would satisfy that request.

Thank you for reviewing the PR. I had some doubts regarding the implementation and had shared a comment

I initially considered modifying both waitTransitGatewayRouteTableAssociationCreated and waitTransitGatewayRouteTableAssociationDeleted. However, I hit a roadblock since these functions are reused in different places — for example, waitTransitGatewayRouteTableAssociationDeleted is also used in transitgateway_policy_table_association.go.

That made me unsure whether this would be the most appropriate or stylistically consistent approach.

I’d really appreciate any feedback or suggestions on the best way to proceed.

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. timeouts Pertains to timeout increases. service/transitgateway Issues and PRs that pertain to the transitgateway service. and removed needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/transitgateway Issues and PRs that pertain to the transitgateway service. size/XS Managed by automation to categorize the size of a PR. timeouts Pertains to timeout increases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ec2_transit_gateway_route_table_association support for timeouts block
2 participants