Skip to content

[Enhancement] Adding parameters to the datasource aws_db_parameter_group #42765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michalschott
Copy link
Contributor

@michalschott michalschott commented May 26, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Currently using datasource aws_db_parameter_group does not expose parameters. In my case I had to use workaround with null, local-exec, aws-cli - would be much easier to have direct access to these parameters.

Relations

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@michalschott michalschott requested a review from a team as a code owner May 26, 2025 09:08
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@michalschott michalschott force-pushed the datasource-db-param-group-parameters branch from 265c62e to f2cd951 Compare May 26, 2025 10:30
Copy link

github-actions bot commented May 26, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. labels May 26, 2025
@michalschott michalschott force-pushed the datasource-db-param-group-parameters branch from c44b29a to 25ad291 Compare May 26, 2025 10:35
@michalschott michalschott changed the title Adding parameters to the datasource aws_db_parameter_group [Enchancement] Adding parameters to the datasource aws_db_parameter_group May 26, 2025
@michalschott michalschott changed the title [Enchancement] Adding parameters to the datasource aws_db_parameter_group [Enhancement] Adding parameters to the datasource aws_db_parameter_group May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant