Skip to content

Tech debt: Use AutoFlEx for aws_rds_export_task #42794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented May 28, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

The aws_rds_export_task resource was one of the first to use terraform-plugin-framework, before the introduction of AutoFlEx.
This PR refactors to use AutoFlEx.

Relations

Relates #38907.
Relates #42741.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRDSExportTask_' PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.3 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSExportTask_ -timeout 360m -vet=off
2025/05/28 14:58:59 Creating Terraform AWS Provider (SDKv2-style)...
2025/05/28 14:58:59 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccRDSExportTask_basic
=== PAUSE TestAccRDSExportTask_basic
=== RUN   TestAccRDSExportTask_optional
=== PAUSE TestAccRDSExportTask_optional
=== CONT  TestAccRDSExportTask_basic
=== CONT  TestAccRDSExportTask_optional
--- PASS: TestAccRDSExportTask_basic (1345.80s)
--- PASS: TestAccRDSExportTask_optional (1771.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1776.639s

@ewbankkit ewbankkit requested a review from a team as a code owner May 28, 2025 19:32
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/XL Managed by automation to categorize the size of a PR. labels May 28, 2025
@ewbankkit ewbankkit added this to the v6.0.0-beta3 milestone May 28, 2025
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit 8ec0437 into release/6.0.0-beta Jun 2, 2025
41 checks passed
@ewbankkit ewbankkit deleted the td-r/aws_rds_export_task-use-autoflex branch June 2, 2025 15:56
Copy link

github-actions bot commented Jun 2, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants