Skip to content

Resolve cloudfrontkeyvaluestore_keys_exclusive being blocked by service quotas with large number of key value pairs #42795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

brittandeyoung
Copy link
Collaborator

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

This PR resolves an issue where you receive an AWS API service quota exception when attempting to update more than 50 key value pairs at once.

Relations

Closes #42789

References

Output from Acceptance Testing

%  make testacc TESTARGS='-run=TestAccCloudFrontKeyValueStoreKeysExclusive' PKG=cloudfrontkeyvaluestore    
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.9 test ./internal/service/cloudfrontkeyvaluestore/... -v -count 1 -parallel 20  -run=TestAccCloudFrontKeyValueStoreKeysExclusive -timeout 360m -vet=off
2025/05/28 16:37:34 Initializing Terraform AWS Provider...
=== RUN   TestAccCloudFrontKeyValueStoreKeysExclusive_basic
=== PAUSE TestAccCloudFrontKeyValueStoreKeysExclusive_basic
=== RUN   TestAccCloudFrontKeyValueStoreKeysExclusive_disappears_KeyValueStore
=== PAUSE TestAccCloudFrontKeyValueStoreKeysExclusive_disappears_KeyValueStore
=== RUN   TestAccCloudFrontKeyValueStoreKeysExclusive_outOfBandAddition
=== PAUSE TestAccCloudFrontKeyValueStoreKeysExclusive_outOfBandAddition
=== RUN   TestAccCloudFrontKeyValueStoreKeysExclusive_outOfBandRemoval
=== PAUSE TestAccCloudFrontKeyValueStoreKeysExclusive_outOfBandRemoval
=== RUN   TestAccCloudFrontKeyValueStoreKeysExclusive_value
=== PAUSE TestAccCloudFrontKeyValueStoreKeysExclusive_value
=== RUN   TestAccCloudFrontKeyValueStoreKeysExclusive_empty
=== PAUSE TestAccCloudFrontKeyValueStoreKeysExclusive_empty
=== RUN   TestAccCloudFrontKeyValueStoreKeysExclusive_maxBatchSize
=== PAUSE TestAccCloudFrontKeyValueStoreKeysExclusive_maxBatchSize
=== CONT  TestAccCloudFrontKeyValueStoreKeysExclusive_basic
=== CONT  TestAccCloudFrontKeyValueStoreKeysExclusive_value
=== CONT  TestAccCloudFrontKeyValueStoreKeysExclusive_outOfBandAddition
=== CONT  TestAccCloudFrontKeyValueStoreKeysExclusive_outOfBandRemoval
=== CONT  TestAccCloudFrontKeyValueStoreKeysExclusive_disappears_KeyValueStore
=== CONT  TestAccCloudFrontKeyValueStoreKeysExclusive_maxBatchSize
=== CONT  TestAccCloudFrontKeyValueStoreKeysExclusive_empty
--- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_disappears_KeyValueStore (31.72s)
--- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_value (42.43s)
--- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_maxBatchSize (43.95s)
--- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_outOfBandAddition (44.36s)
--- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_basic (44.45s)
--- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_outOfBandRemoval (51.29s)
--- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_empty (59.12s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfrontkeyvaluestore    64.971s

...

@brittandeyoung brittandeyoung requested a review from a team as a code owner May 28, 2025 20:47
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

github-actions bot commented May 28, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudfrontkeyvaluestore Issues and PRs that pertain to the cloudfrontkeyvaluestore service. size/L Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels May 28, 2025
@brittandeyoung brittandeyoung added the bug Addresses a defect in current functionality. label May 29, 2025
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. service/cloudfrontkeyvaluestore Issues and PRs that pertain to the cloudfrontkeyvaluestore service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cloudfrontkeyvaluestore_keys_exclusive: Maximum key values pairs service quota
2 participants