updates such that gateway-rs builds as lib #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lthiery
changed the title
madninja
reviewed
Apr 3, 2025
madninja
reviewed
Apr 3, 2025
I was seeing if I could bump the toolchain version but too much of a hassle, indeed |
lthiery
force-pushed
the
lthiery/updates
branch
2 times, most recently
from
be92a69 to
2f78dd8
Compare
|
@madninja It looks like the quay credentials are no longer valid? |
lthiery
changed the title
|
Shall we just deprecate the quay step and leave its recovery as an open issue? |
Nope.. looking at it.. perhaps address the other comments? |
I addressed all comments and was awaiting response. Things were stalled on quay |
madninja
approved these changes
Apr 9, 2025
lthiery
force-pushed
the
lthiery/updates
branch
from
5783a27 to
aa2b5e0
Compare
lthiery
force-pushed
the
lthiery/updates
branch
from
aa2b5e0 to
ae3d7c8
Compare
madninja
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gateway-rs is not up to date with latest helium-proto and the declaration on "main" is inaccurate