feat(lsp): sort diagnostic picker by severity #13806
Open
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was brought up again in #3543 and I think that while the search options to narrow a scope down is very nice, I find myself searching for errors as the most common case, which requires to always have a
%s Esearch. This works, but one issue is that theSPACE+', for example, doesnt update with new info after changing things. And the picker doesnt persist the queries, requiring a retype of the same thing many times as issues are addressed.Sorting by default optimizes this flow. And the search options still provide a way to narrow from there. While I think this should be the default, there was mention of configuration, but most cases need a search, which bypasses any specific search order anyways (I think it uses a different search sort mechanism (nucleos?)).