added "backfilling of keystones" #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AL-CT hold off on review for now, I am going to take a closer look at changes to the snap protocol before asserting which way to handle this 🤔 |
AL-CT
reviewed
May 16, 2025
AL-CT
reviewed
May 16, 2025
AL-CT
reviewed
May 16, 2025
AL-CT
reviewed
May 16, 2025
AL-CT
previously requested changes
May 16, 2025
core/blockchain.go
Outdated
| } | ||
|
|
||
| if l2Keystone.L2BlockNumber >= hemi.KeystoneHeaderPeriod { | ||
| // 475 |
AL-CT
reviewed
May 16, 2025
core/blockchain.go
Outdated
| // so continue the for loop if we inserted a new one to handle | ||
| // more missing ones | ||
|
|
||
| if bc.keystonesBackfilled && l2BlockNumber < finalizedBlockNumber && !insertedNew { |
There was a problem hiding this comment.
nit, probably need a read lock to read bc.keystonesBackfilled
There was a problem hiding this comment.
yes we absolutely do 👍 I'll update
upon startup, "backfill" keystones to genesis. this shouldn't take too long. upon each new keystone, backfill keystones from unsafe head to either finalized block or until we have populated all non-found keystones (missing blocks)
ClaytonNorthey92
force-pushed
the
clayton/keystone-backfill
branch
from
9adfc65 to
97b0fe8
Compare
ClaytonNorthey92
added a commit
that referenced
this pull request
May 16, 2025
upon startup, "backfill" keystones to genesis. this shouldn't take too long. upon each new keystone, backfill keystones from unsafe head to either finalized block or until we have populated all non-found keystones (missing blocks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on startup, op-geth will backfill all keystones to genesis in an upsert fashion
afterwards, upon each new keystone, it will backfill up to the first keystone found