Store Scope in OLPHttpClient to prolong lifetime #1619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An attempt to make static objects to live long enough when parent objects are destructed randomly Relates-To: HERESDK-6943 Signed-off-by: Rustam Gamidov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1619 +/- ##
==========================================
+ Coverage 80.21% 80.26% +0.05%
==========================================
Files 348 348
Lines 13882 13883 +1
Branches 1483 1483
==========================================
+ Hits 11135 11143 +8
+ Misses 2148 2143 -5
+ Partials 599 597 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mykhailo-kuchma
approved these changes
Jun 16, 2025
andrey-kashcheev
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to make static objects to live long enough when parent objects are destructed randomly
Resolves #1613
Relates-To: HERESDK-6943