-
-
Notifications
You must be signed in to change notification settings - Fork 177
Add interceptor indexes #2029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interceptor indexes #2029
Conversation
|
🦋 Changeset detectedLatest commit: 1f99066 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly agree with the changes! I understand you prefer the Axios-like syntax. My only ask is to preserve the current behaviour so it doesn't break for people
@mrlubos I've made additional changes, but the failing test fails for me on Main as well as the branch. How would you prefer to proceed? |
Thanks! I'll have a look at the failing test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe to make your tests pass... build each touched client, i.e. pnpm client fetch build
, pnpm client custom build
, and seems you want to also do pnpm client next build
. After that, update actual tests with pnpm openapi-ts-tests test:update
f84bab2
to
a8d5ed3
Compare
a8d5ed3
to
98c2474
Compare
@hey-api/client-axios
@hey-api/client-fetch
@hey-api/client-next
@hey-api/client-nuxt
@hey-api/nuxt
@hey-api/openapi-ts
@hey-api/vite-plugin
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2029 +/- ##
=======================================
Coverage 22.54% 22.54%
=======================================
Files 258 258
Lines 22761 22761
Branches 820 820
=======================================
Hits 5132 5132
Misses 17623 17623
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@mrlubos I've built the clients and updated the tests. Everything is passing, is there anything else I need to do to get these changes merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Solves #2018