Skip to content

DLS-8071: Fix failing unit tests #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 22, 2023

Conversation

johno1985
Copy link
Contributor

Some code formatting
Use recommended test libraries
Removed some unused files and code
Fixed failing unit tests

@platops-pr-bot
Copy link

  • Scala can be updated from 2.12.13 to 2.13.8 in build.sbt
  • Add uk.gov.hmrc.bootstrap-test-play-28 in project/AppDependencies.scala to provide recommended test dependencies. Use a variable to keep version in sync with bootstrap-play

@platops-pr-bot
Copy link

  • Add uk.gov.hmrc.bootstrap-test-play-28 in project/AppDependencies.scala to provide recommended test dependencies. Use a variable to keep version in sync with bootstrap-play
  • Scala can be updated from 2.12.13 to 2.13.8 in build.sbt

@johno1985 johno1985 force-pushed the DLS-8071/Jonathan/fix-failing-unit-tests branch from bf59bdf to f52621a Compare May 18, 2023 15:58
@LAJW LAJW self-requested a review May 18, 2023 16:34
LAJW
LAJW previously approved these changes May 18, 2023
build.sbt Outdated
@@ -8,6 +8,8 @@ import wartremover.Wart

val appName = "help-to-save-api"

val silencerVersion = "1.7.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also downgrades the plugin version (1.7.11 -> 1.7.7)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, spotted, correcting now

@platops-pr-bot
Copy link

  • Add uk.gov.hmrc.bootstrap-test-play-28 in project/AppDependencies.scala to provide recommended test dependencies. Use a variable to keep version in sync with bootstrap-play
  • Scala can be updated from 2.12.13 to 2.13.8 in build.sbt

@johno1985 johno1985 merged commit dccc722 into main May 22, 2023
@johno1985 johno1985 deleted the DLS-8071/Jonathan/fix-failing-unit-tests branch May 22, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants