Skip to content

DLS-10979: Clean up HttpClientV2 upgrade for help-to-save-api. #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

vamsikrishnapujari
Copy link
Contributor

No description provided.

@platops-pr-bot
Copy link

@karolina-zaborska
Copy link
Contributor

karolina-zaborska commented Oct 22, 2024

The changes are failing due to the coverage minimum not being met [93.73% < 94.00%], try to address the bot changes and maybe that will help.

Also, we usually aim to have a number of the ticket in the name of a PR so "DLS-10979" + "name of the pr" like DLS-10979: HttpClientV2 test cases fix

@platops-pr-bot
Copy link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove that one too rather than commenting that out

@platops-pr-bot
Copy link

@vamsikrishnapujari vamsikrishnapujari force-pushed the DLS-10979/vamsi/hts-api branch 2 times, most recently from c8f2806 to 9ff2c78 Compare October 22, 2024 12:36
Copy link
Contributor

@karolina-zaborska karolina-zaborska Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all those elements that you commented out here, the metrics, auditing and #play.modules.enabled += "uk.gov.hmrc.play.audit.AuditModule". No need to have them.

Also, if would be great if we could do it in a separate commit, so one would be focusing on HttpClientV2 changes and the other one on these

@vamsikrishnapujari vamsikrishnapujari changed the title Commiting code changes for test cases fix for HttpClientV2. DLS-10979: Clean up HttpClientV2 upgrade for help-to-save-api. Oct 22, 2024
@vamsikrishnapujari vamsikrishnapujari merged commit e1b8499 into main Oct 22, 2024
1 check passed
@vamsikrishnapujari vamsikrishnapujari deleted the DLS-10979/vamsi/hts-api branch October 22, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants