-
Notifications
You must be signed in to change notification settings - Fork 1
DLS-10979: Clean up HttpClientV2 upgrade for help-to-save-api. #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The changes are failing due to the coverage minimum not being met [93.73% < 94.00%], try to address the bot changes and maybe that will help. Also, we usually aim to have a number of the ticket in the name of a PR so "DLS-10979" + "name of the pr" like DLS-10979: HttpClientV2 test cases fix |
9250211
to
2bdb4d4
Compare
|
2bdb4d4
to
0a83092
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove that one too rather than commenting that out
|
c8f2806
to
9ff2c78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove all those elements that you commented out here, the metrics, auditing and #play.modules.enabled += "uk.gov.hmrc.play.audit.AuditModule". No need to have them.
Also, if would be great if we could do it in a separate commit, so one would be focusing on HttpClientV2 changes and the other one on these
9ff2c78
to
e730a4f
Compare
e730a4f
to
c220c50
Compare
No description provided.