Skip to content

Hugo/DLS-11581: Scala3 Upgrade #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 23, 2025
Merged

Hugo/DLS-11581: Scala3 Upgrade #198

merged 6 commits into from
May 23, 2025

Conversation

HG-Accenture
Copy link
Contributor

No description provided.

@platops-pr-bot
Copy link

  • You have multiple routes files conf/app.routes, conf/definition.routes using the same package uk.gov.hmrc.helptosaveapi.controllers, which leads to collision with the reverse routes. Please ensure each routes file refers to a different package.

@HG-Accenture HG-Accenture force-pushed the Hugo/DLS-11581 branch 2 times, most recently from 2c697bd to 4831e9b Compare May 6, 2025 16:35
@HG-Accenture
Copy link
Contributor Author

I have decreased the statement coverage from 94% to 90%. I will create a new ticket to increase the test coverage back to 94%, as the current tests in the scala2 version did not accurately provide insights into the test coverage.

@HG-Accenture
Copy link
Contributor Author

The project has also been refactored to exclude Play's internal JSON functions from testing by relocating them to a path that is excluded from the coverage statistics.

@platops-pr-bot
Copy link

  • You have multiple routes files conf/app.routes, conf/definition.routes using the same package uk.gov.hmrc.helptosaveapi.controllers, which leads to collision with the reverse routes. Please ensure each routes file refers to a different package.
  • controllers.com.kenshoo.play.metrics.MetricsController.needsAuth in conf/application.conf is not needed. It is no longer used by Auth.

@HG-Accenture HG-Accenture force-pushed the Hugo/DLS-11581 branch 3 times, most recently from d387c1c to b9fe96a Compare May 22, 2025 10:05
@platops-pr-bot
Copy link

  • You have multiple routes files conf/app.routes, conf/definition.routes using the same package uk.gov.hmrc.helptosaveapi.controllers, which leads to collision with the reverse routes. Please ensure each routes file refers to a different package.
  • uk.gov.hmrc:bootstrap-backend-play-30 can be updated to 9.12.0 in project/AppDependencies.scala.
  • uk.gov.hmrc:bootstrap-test-play-30 can be updated to 9.12.0 in project/AppDependencies.scala.
  • controllers.com.kenshoo.play.metrics.MetricsController.needsAuth in conf/application.conf is not needed. It is no longer used by Auth.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this deleted?

@platops-pr-bot
Copy link

  • uk.gov.hmrc:bootstrap-backend-play-30 can be updated to 9.12.0 in project/AppDependencies.scala.
  • uk.gov.hmrc:bootstrap-test-play-30 can be updated to 9.12.0 in project/AppDependencies.scala.
  • controllers.com.kenshoo.play.metrics.MetricsController.needsAuth in conf/application.conf is not needed. It is no longer used by Auth.
  • You have multiple routes files conf/app.routes, conf/definition.routes using the same package uk.gov.hmrc.helptosaveapi.controllers, which leads to collision with the reverse routes. Please ensure each routes file refers to a different package.
  • Runtime issues may occur. Change org.playframework:sbt-plugin to 3.0.7 in project/plugins.sbt - to match what uk.gov.hmrc.bootstrap-backend-play-30 uses

@platops-pr-bot
Copy link

  • uk.gov.hmrc:bootstrap-backend-play-30 can be updated to 9.12.0 in project/AppDependencies.scala.
  • uk.gov.hmrc:bootstrap-test-play-30 can be updated to 9.12.0 in project/AppDependencies.scala.
  • controllers.com.kenshoo.play.metrics.MetricsController.needsAuth in conf/application.conf is not needed. It is no longer used by Auth.
  • Runtime issues may occur. Change org.playframework:sbt-plugin to 3.0.7 in project/plugins.sbt - to match what uk.gov.hmrc.bootstrap-backend-play-30 uses
  • You have multiple routes files conf/app.routes, conf/definition.routes using the same package uk.gov.hmrc.helptosaveapi.controllers, which leads to collision with the reverse routes. Please ensure each routes file refers to a different package.

@HG-Accenture HG-Accenture merged commit 7ca6f2b into main May 23, 2025
1 check passed
@HG-Accenture HG-Accenture deleted the Hugo/DLS-11581 branch May 23, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants