Skip to content

upgrade ubuntu version number to 25.04 #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

Conversation

BJNFNE
Copy link
Collaborator

@BJNFNE BJNFNE commented May 15, 2025

Summary by CodeRabbit

  • New Features

    • Added detection support for the iTunes Library binary format using the "Detect It Easy" tool.
    • Added detection support for the DCP archive format.
    • Added detection support for the Xbox 360 System Font (.XTT) file format.
    • Added detection support for the BSP file format used by Valve's Source engine.
    • Added detection support for the Medievil WAD (MWD) archive format.
    • Added detection support for the TUN audio format used by Lego Racers.
    • Added detection support for Windows Registry Hive (.HIV) files.
    • Added detection support for the RVZ archive format.
  • Documentation

    • Updated Qt installation instructions to include support for Ubuntu versions 21.04 through 25.04.
    • Improved markdown formatting in the build documentation.

Copy link

coderabbitai bot commented May 15, 2025

Walkthrough

The changes update documentation to include Ubuntu 25.04 in Qt installation instructions and correct markdown formatting. Additionally, new detection rules for identifying iTunes Library, DCP archive, Xbox 360 System Font, Valve BSP, Medievil WAD archive, TUN audio, Windows Registry Hive, and RVZ archive binary files are introduced for the "Detect It Easy" tool, using signature-based detection functions.

Changes

File(s) Change Summary
docs/BUILD.md Extended supported Ubuntu versions for Qt installation to 25.04 and added a missing newline at EOF.
db/Binary/bin.ITL.1.sg Added new detection rule for "Detect It Easy" to identify iTunes Library binary files by signature.
db/Binary/archive.DCP.sg Added new detection rule for "Detect It Easy" to identify DCP archive format by signature.
db/Binary/font.XTT.sg Added new detection rule for "Detect It Easy" to identify Xbox 360 System Font files by signature.
db/Binary/bin.BSP.1.sg Added new detection rule for "Detect It Easy" to identify Valve Source engine BSP files by signature.
db/Binary/archive.MWD.sg Added new detection rule for "Detect It Easy" to identify Medievil WAD archive format by signature.
db/Binary/audio.TUN.sg Added new detection rule for "Detect It Easy" to identify TUN audio files by signature.
db/Binary/bin.HIV.1.sg Added new detection rule for "Detect It Easy" to identify Windows Registry Hive files by signature.
db/Binary/archive.RVZ.sg Added new detection rule for "Detect It Easy" to identify RVZ archive format by signature.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DetectItEasy
    participant ITLRule
    participant DCPRule
    participant XTTRule
    participant BSPRule
    participant MWDRule
    participant TUNRule
    participant HIVRule
    participant RVZRule

    User->>DetectItEasy: Scan binary file
    alt File is iTunes Library format
        DetectItEasy->>ITLRule: Call detect()
        ITLRule->>ITLRule: Check for "hdfm" signature
        ITLRule-->>DetectItEasy: Return detection result (true)
    else File is DCP archive format
        DetectItEasy->>DCPRule: Call detect()
        DCPRule->>DCPRule: Check for DE AD C0 DE 4A 55 4E 4B signature
        DCPRule-->>DetectItEasy: Return detection result (true)
    else File is Xbox 360 System Font format
        DetectItEasy->>XTTRule: Call detect()
        XTTRule->>XTTRule: Check for "xttf" signature
        XTTRule-->>DetectItEasy: Return detection result (true)
    else File is Valve BSP format
        DetectItEasy->>BSPRule: Call detect()
        BSPRule->>BSPRule: Check for "56 42 53 50 15" signature
        BSPRule-->>DetectItEasy: Return detection result (true)
    else File is Medievil WAD archive format
        DetectItEasy->>MWDRule: Call detect()
        MWDRule->>MWDRule: Check for "44 41 57 4D" signature
        MWDRule-->>DetectItEasy: Return detection result (true)
    else File is TUN audio format
        DetectItEasy->>TUNRule: Call detect()
        TUNRule->>TUNRule: Check for "41 4C 50" signature
        TUNRule-->>DetectItEasy: Return detection result (true)
    else File is Windows Registry Hive format
        DetectItEasy->>HIVRule: Call detect()
        HIVRule->>HIVRule: Check for "regf" signature
        HIVRule-->>DetectItEasy: Return detection result (true)
    else File is RVZ archive format
        DetectItEasy->>RVZRule: Call detect()
        RVZRule->>RVZRule: Check for "RVZ" signature
        RVZRule-->>DetectItEasy: Return detection result (true)
    else Unknown format
        DetectItEasy->>ITLRule: Call detect()
        ITLRule-->>DetectItEasy: Return detection result (false)
        DetectItEasy->>DCPRule: Call detect()
        DCPRule-->>DetectItEasy: Return detection result (false)
        DetectItEasy->>XTTRule: Call detect()
        XTTRule-->>DetectItEasy: Return detection result (false)
        DetectItEasy->>BSPRule: Call detect()
        BSPRule-->>DetectItEasy: Return detection result (false)
        DetectItEasy->>MWDRule: Call detect()
        MWDRule-->>DetectItEasy: Return detection result (false)
        DetectItEasy->>TUNRule: Call detect()
        TUNRule-->>DetectItEasy: Return detection result (false)
        DetectItEasy->>HIVRule: Call detect()
        HIVRule-->>DetectItEasy: Return detection result (false)
        DetectItEasy->>RVZRule: Call detect()
        RVZRule-->>DetectItEasy: Return detection result (false)
    end
    DetectItEasy-->>User: Report detection result
Loading

Poem

A hop, a skip through docs we go,
Ubuntu’s versions now do grow.
New rules sniff bytes with flair and cheer,
"hdfm," DCP, and "xttf" appear.
BSP, WAD, TUN, Hive, and RVZ in place—
A rabbit’s joy in every trace! 🐇🎉✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/BUILD.md (1)

26-26: Use consistent unordered-list style
markdownlint (MD004) flags the use of - here; the rest of this document uses * for bullets. Consider updating this line to maintain consistency:

- Ubuntu 21.04-25.04
+ * Ubuntu 21.04-25.04
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 288c98e and 180dccf.

📒 Files selected for processing (1)
  • docs/BUILD.md (2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/BUILD.md

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

🔇 Additional comments (2)
docs/BUILD.md (2)

26-26: Extend supported Ubuntu versions to 25.04
The range has been updated from 21.04–22.04 to 21.04–25.04 in line with the PR goal. Please verify that the packages qtchooser and qt5-qmake are available and unchanged in Ubuntu 25.04, and document any new prerequisites if needed.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


165-165: Add trailing newline for proper Markdown formatting
The inserted newline at EOF prevents rendering issues in some parsers.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/BUILD.md (1)

26-26: Ensure list style consistency
markdownlint flagged an unordered list using a dash (-) while the configured style expects an asterisk (*). For consistency, update this line (and any similar list items) to use *.

- - Ubuntu 21.04-25.04
+ * Ubuntu 21.04-25.04
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 180dccf and f436e96.

📒 Files selected for processing (1)
  • docs/BUILD.md (2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/BUILD.md

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

🔇 Additional comments (1)
docs/BUILD.md (1)

165-165: Verify trailing newline
The added blank line at the end of the file ensures proper markdown formatting. This aligns with best practices—nothing further to change here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/BUILD.md (1)

26-26: Consistent list marker style for markdownlint
The project’s markdownlint (MD004) expects asterisk-based list markers. Consider replacing the dash (-) with an asterisk (*) for this item or updating your lint rule to allow dashes.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 5a55ea7 and b2ea291.

📒 Files selected for processing (3)
  • db/Binary/bin.ITL.1.sg (1 hunks)
  • docs/BUILD.md (2 hunks)
  • todo.txt (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • todo.txt
🚧 Files skipped from review as they are similar to previous changes (1)
  • db/Binary/bin.ITL.1.sg
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/BUILD.md

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

🔇 Additional comments (2)
docs/BUILD.md (2)

26-26: Update supported Ubuntu versions to include 25.04
The instruction has been correctly updated from “21.04–22.04” to “21.04–25.04” to reflect the new Ubuntu LTS support.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


165-165: Add trailing newline for proper Markdown formatting
Including a final newline prevents Markdown parsers from ignoring the last line and avoids formatting issues.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/BUILD.md (1)

26-26: Approve Ubuntu version bump; enforce consistent list style

The version range has been correctly updated to include Ubuntu 25.04. However, this list item uses a hyphen (-) while the rest of the document uses asterisks (*) for unordered lists. Please update it to:

- Ubuntu 21.04-25.04
+ * Ubuntu 21.04-25.04
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between b2ea291 and 31c3642.

📒 Files selected for processing (2)
  • db/Binary/bin.ITL.1.sg (1 hunks)
  • docs/BUILD.md (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • db/Binary/bin.ITL.1.sg
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/BUILD.md

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

🔇 Additional comments (1)
docs/BUILD.md (1)

165-165: Ensure newline at end of file

Adding a trailing newline after the closing code fence ensures proper Markdown rendering and avoids potential parser warnings.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/BUILD.md (1)

26-26: Ensure list style consistency and maintain punctuation.

The Ubuntu version list item uses a dash and lacks a trailing colon, whereas earlier version entries use a dash plus colon. For uniformity and to satisfy markdown lint (MD004), consider:

  • Switching the dash (-) to an asterisk (*) to match other bullet lists.
  • Adding a trailing colon (:) to mirror the style of the “Ubuntu 14.04-20.04:” entry.

Apply this diff:

- - Ubuntu 21.04-25.04
+ * Ubuntu 21.04-25.04:
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 31c3642 and 9b81e95.

📒 Files selected for processing (2)
  • db/Binary/bin.ITL.1.sg (1 hunks)
  • docs/BUILD.md (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • db/Binary/bin.ITL.1.sg
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/BUILD.md

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

🔇 Additional comments (1)
docs/BUILD.md (1)

165-165: 👍 Newline at end-of-file added.

Great catch adding the missing newline to comply with POSIX and markdown standards. This prevents potential formatting issues.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/BUILD.md (1)

26-26: Maintain consistent section formatting
The Ubuntu version range entry is missing a trailing colon, which is used in the “Ubuntu 14.04-20.04:” line. Also, if you’d like to satisfy markdownlint’s MD004 rule, consider using the same bullet marker (- vs *) across all lists.

- - Ubuntu 21.04-25.04
+ - Ubuntu 21.04-25.04:
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 9b81e95 and 9f0ed2a.

📒 Files selected for processing (3)
  • db/Binary/archive.DCP.sg (1 hunks)
  • db/Binary/bin.ITL.1.sg (1 hunks)
  • docs/BUILD.md (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • db/Binary/archive.DCP.sg
🚧 Files skipped from review as they are similar to previous changes (1)
  • db/Binary/bin.ITL.1.sg
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/BUILD.md

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

🔇 Additional comments (1)
docs/BUILD.md (1)

165-165: POSIX-style trailing newline added
Good catch adding the final newline—this ensures POSIX compliance and avoids unexpected diff noise.

@BJNFNE BJNFNE force-pushed the ubuntu-2504 branch 2 times, most recently from 71873df to cc659f3 Compare May 17, 2025 08:02
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/BUILD.md (1)

26-26: Standardize list styling and punctuation for the new Ubuntu version
You’ve correctly extended support to Ubuntu 25.04, but for consistency with the earlier entry (- Ubuntu 14.04-20.04:), consider:

  • Adding a trailing colon
  • Using the same list marker across the doc (either all dashes or all asterisks)

Suggested diff:

- - Ubuntu 21.04-25.04
+ - Ubuntu 21.04-25.04:
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 9f0ed2a and cc659f3.

📒 Files selected for processing (4)
  • db/Binary/archive.DCP.sg (1 hunks)
  • db/Binary/bin.ITL.1.sg (1 hunks)
  • db/Binary/font.XTT.sg (1 hunks)
  • docs/BUILD.md (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • db/Binary/font.XTT.sg
🚧 Files skipped from review as they are similar to previous changes (2)
  • db/Binary/bin.ITL.1.sg
  • db/Binary/archive.DCP.sg
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/BUILD.md

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

🔇 Additional comments (1)
docs/BUILD.md (1)

165-165: Confirm newline at end of file
Good catch on adding the final newline—it ensures proper rendering and compatibility with POSIX tools.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/BUILD.md (1)

26-26: Use consistent Markdown list style and punctuation

The new Ubuntu entry uses a dash and omits the trailing colon, which is inconsistent with other list items. The project’s markdownlint configuration expects asterisk bullets and colons:

- - Ubuntu 21.04-25.04
+ * Ubuntu 21.04-25.04:
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between cc659f3 and 127bfc8.

📒 Files selected for processing (5)
  • db/Binary/archive.DCP.sg (1 hunks)
  • db/Binary/bin.BSP.1.sg (1 hunks)
  • db/Binary/bin.ITL.1.sg (1 hunks)
  • db/Binary/font.XTT.sg (1 hunks)
  • docs/BUILD.md (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • db/Binary/bin.BSP.1.sg
🚧 Files skipped from review as they are similar to previous changes (3)
  • db/Binary/bin.ITL.1.sg
  • db/Binary/archive.DCP.sg
  • db/Binary/font.XTT.sg
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/BUILD.md

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

🔇 Additional comments (2)
docs/BUILD.md (2)

26-26: Approve Ubuntu version range bump

Extending support up to Ubuntu 25.04 aligns perfectly with the PR objective to upgrade the Ubuntu version in the build documentation.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


165-165: Ensure newline at end of file

A final newline is essential for POSIX compliance and avoids edge-case rendering issues in some Markdown parsers. This addition is correct.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
docs/BUILD.md (2)

26-26: Ensure consistency in Markdown list formatting

  • Add a colon at the end of the Ubuntu version item to mirror the existing syntax for the - Ubuntu 14.04-20.04: entry.
  • Optionally, consider unifying list markers across the file (all dashes or all asterisks) to satisfy markdownlint’s MD004 rule.

Apply:

- - Ubuntu 21.04-25.04
+ - Ubuntu 21.04-25.04:
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


165-165: Add a trailing newline at end of file

POSIX‐compliant text files should end with a newline. Please ensure there’s a blank line after the final backticks.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 127bfc8 and 1816afd.

📒 Files selected for processing (6)
  • db/Binary/archive.DCP.sg (1 hunks)
  • db/Binary/archive.MWD.sg (1 hunks)
  • db/Binary/bin.BSP.1.sg (1 hunks)
  • db/Binary/bin.ITL.1.sg (1 hunks)
  • db/Binary/font.XTT.sg (1 hunks)
  • docs/BUILD.md (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • db/Binary/archive.MWD.sg
🚧 Files skipped from review as they are similar to previous changes (4)
  • db/Binary/bin.ITL.1.sg
  • db/Binary/font.XTT.sg
  • db/Binary/bin.BSP.1.sg
  • db/Binary/archive.DCP.sg
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/BUILD.md

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/BUILD.md (1)

26-26: Use consistent list markers in Markdown
markdownlint (MD004) expects * for unordered lists instead of -. Please update the Ubuntu bullets accordingly:

- - Ubuntu 21.04-25.04
+ * Ubuntu 21.04-25.04
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 1816afd and 60b4b98.

📒 Files selected for processing (7)
  • db/Binary/archive.DCP.sg (1 hunks)
  • db/Binary/archive.MWD.sg (1 hunks)
  • db/Binary/audio.TUN.sg (1 hunks)
  • db/Binary/bin.BSP.1.sg (1 hunks)
  • db/Binary/bin.ITL.1.sg (1 hunks)
  • db/Binary/font.XTT.sg (1 hunks)
  • docs/BUILD.md (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • db/Binary/audio.TUN.sg
🚧 Files skipped from review as they are similar to previous changes (5)
  • db/Binary/bin.ITL.1.sg
  • db/Binary/bin.BSP.1.sg
  • db/Binary/font.XTT.sg
  • db/Binary/archive.MWD.sg
  • db/Binary/archive.DCP.sg
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/BUILD.md

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

🔇 Additional comments (2)
docs/BUILD.md (2)

26-26: Upgrade Ubuntu version range to 25.04
The supported Ubuntu range is correctly extended to include 25.04, matching the PR objective.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


165-165: Ensure file ends with a newline
Adding a trailing newline improves POSIX compliance and Markdown rendering.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/BUILD.md (1)

26-26: Consistent list style and punctuation
To match the asterisk-based lists elsewhere and include the trailing colon, please apply:

- - Ubuntu 21.04-25.04
+ * Ubuntu 21.04-25.04:
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 60b4b98 and 14f8f26.

📒 Files selected for processing (8)
  • db/Binary/archive.DCP.sg (1 hunks)
  • db/Binary/archive.MWD.sg (1 hunks)
  • db/Binary/audio.TUN.sg (1 hunks)
  • db/Binary/bin.BSP.1.sg (1 hunks)
  • db/Binary/bin.HIV.1.sg (1 hunks)
  • db/Binary/bin.ITL.1.sg (1 hunks)
  • db/Binary/font.XTT.sg (1 hunks)
  • docs/BUILD.md (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • db/Binary/bin.HIV.1.sg
🚧 Files skipped from review as they are similar to previous changes (6)
  • db/Binary/font.XTT.sg
  • db/Binary/bin.BSP.1.sg
  • db/Binary/archive.MWD.sg
  • db/Binary/bin.ITL.1.sg
  • db/Binary/audio.TUN.sg
  • db/Binary/archive.DCP.sg
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/BUILD.md

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

🔇 Additional comments (2)
docs/BUILD.md (2)

26-26: Supported Ubuntu version updated
The range has been correctly extended to cover Ubuntu 21.04 through 25.04, ensuring Qt installation instructions remain current.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


165-165: Ensure final newline for POSIX compliance
Adding a trailing newline at end-of-file is good practice for POSIX tools and avoids potential warnings from linters or diff tools.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/BUILD.md (1)

26-26: Unify list item formatting and syntax
The new Ubuntu version entry is missing the trailing colon and uses a dash, whereas earlier lists and markdownlint (MD004) prefer asterisk bullets. To maintain consistency and satisfy the linter, you can either:

Option A – Convert to asterisk bullets for both versions:

- Ubuntu 14.04-20.04:
- Ubuntu 21.04-25.04
+ * Ubuntu 14.04-20.04:
+ * Ubuntu 21.04-25.04:

Option B – If you prefer dashes, at minimum add the colon:

- Ubuntu 21.04-25.04
+ Ubuntu 21.04-25.04:
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 14f8f26 and df58d2e.

📒 Files selected for processing (9)
  • db/Binary/archive.DCP.sg (1 hunks)
  • db/Binary/archive.MWD.sg (1 hunks)
  • db/Binary/archive.RVZ.sg (1 hunks)
  • db/Binary/audio.TUN.sg (1 hunks)
  • db/Binary/bin.BSP.1.sg (1 hunks)
  • db/Binary/bin.HIV.1.sg (1 hunks)
  • db/Binary/bin.ITL.1.sg (1 hunks)
  • db/Binary/font.XTT.sg (1 hunks)
  • docs/BUILD.md (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • db/Binary/archive.RVZ.sg
🚧 Files skipped from review as they are similar to previous changes (7)
  • db/Binary/archive.MWD.sg
  • db/Binary/audio.TUN.sg
  • db/Binary/bin.ITL.1.sg
  • db/Binary/bin.HIV.1.sg
  • db/Binary/bin.BSP.1.sg
  • db/Binary/font.XTT.sg
  • db/Binary/archive.DCP.sg
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/BUILD.md

26-26: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

🔇 Additional comments (1)
docs/BUILD.md (1)

165-165: Approve trailing newline addition
Including a newline at the end of the file ensures POSIX-compliant formatting and avoids issues in tools that expect it.

@DosX-dev DosX-dev merged commit a55feec into horsicq:master May 19, 2025
1 check passed
@BJNFNE BJNFNE deleted the ubuntu-2504 branch May 19, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants