WIP: Delete file to trigger any "first touch" calls #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some storage systems (DAOS, PVFS, possibly others) do a "library init" the very first time a program calls MPI_File_Open or MPI_File_delete. In some ways it's entirely fair to include these first touch time but it can also obscure the effects of optimizations or tuning to have one of the iterations consistently take 10x longer.
adilger
reviewed
May 1, 2025
There was a problem hiding this comment.
I think this should be a configurable option, and IMHO not enabled by default. If the initialization time is so significant that it is affecting the benchmark time, then it is also likely significant enough that it affects application runtime and should be measured and not hidden.
Maybe the initialization should be printed as part of the test output?
|
Yeah, definitely should be an option. I should be running each iteration/config of the benchmark for tens of seconds anyway, so a one second initialization shouldn't be significant... Just takes a lot longer to parameter sweep (hours, days?) when doing it the right way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some storage systems (DAOS, PVFS, possibly others) do a "library init" the very first time a program calls MPI_File_Open or MPI_File_delete.
In some ways it's entirely fair to include these first touch time but it can also obscure the effects of optimizations or tuning to have one of the iterations consistently take 10x longer.
Since I don't know if this is a good idea or not, I thought I'd fire off this pull request to see if the community had any thoughts