Skip to content

fix: Improved attr-value-no-duplication logic #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

coliff
Copy link
Member

@coliff coliff commented Jun 17, 2025

Skip checking style tags, SVGs and media.

@coliff coliff requested a review from thedaviddias as a code owner June 17, 2025 05:57
@coliff coliff changed the title fix: Improved attr-value-no-duplication logic fix: Improved attr-value-no-duplication logic Jun 17, 2025
@github-actions github-actions bot added the test label Jun 17, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces improved logic for the attr-value-no-duplication rule, specifically by skipping SVG elements and style attributes, and adding special parsing for media attributes. A critical issue was found where media attributes are unintentionally skipped before their new parsing logic can be applied. A minor suggestion was made to clarify a test description related to media attributes. Once the primary issue is addressed, the changes should correctly enhance the rule's behavior.

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (95e6a13) to head (f591c97).
Report is 84 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #1663      +/-   ##
===========================================
+ Coverage   96.99%   100.00%   +3.00%     
===========================================
  Files           2         1       -1     
  Lines        1628         1    -1627     
  Branches      335         0     -335     
===========================================
- Hits         1579         1    -1578     
+ Misses         49         0      -49     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf955ef...f591c97. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coliff coliff merged commit aadd4cf into main Jun 17, 2025
20 checks passed
@coliff coliff deleted the dev/coliff/improved-duplicate-value-logic branch June 17, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant