Fix Wan AccVideo/CausVid fuse_lora #11856
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Both commits fix the issue of not allowing |
| if key.endswith((".diff", ".diff_b")) and "norm" in key: | ||
| # NOTE: we don't support this because norm layer diff keys are just zeroed values. We can support it | ||
| # in future if needed and they are not zeroed. | ||
| original_state_dict.pop(key) |
There was a problem hiding this comment.
Not a blocker but might just quickly zero if it's all zeros:
There was a problem hiding this comment.
From the original codebases where this comes from, I don't think these keys can be anything but zero and yesterday's investigation revealed the same. Probably best to not do anything else here IMO
| original_state_dict.pop(key) | ||
| logger.debug(f"Removing {key} key from the state dict as it is a norm diff key. This is unsupported.") | ||
|
|
||
| if "time_projection" in key and not has_time_projection_weight: |
|
For some reason the tests fail with the latest main merged. It's again one of those errors that when I try to reproduce locally, just passes. If I run the test alone, it passes. If I run all the tests, the test fails. 😢 |
|
@a-r-r-o-w yeah the VACE tests seem to be a bit |
* fix * actually, better fix * empty commit; trigger tests again * mark wanvace test as flaky
Both AccVideo and CausVid work on my end with fuse_lora.
@apolinario Could you give this a try and see if it resolves the issue you faced?