Fix broken SAM after #39120 #39289
Merged
Fix broken SAM after #39120 #39289
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[For maintainers] Suggested jobs to run (before merge) run-slow: sam, sam_hq |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
reviewed
Jul 9, 2025
| @@ -787,7 +787,7 @@ def forward( | |||
| keys = keys + attn_out | |||
|
|
|||
| keys = self.layer_norm4(keys) | |||
| return query, keys, attn_out | |||
| return queries, keys, attn_out | |||
There was a problem hiding this comment.
ah interesting you odn't return query used to compute attn_out!
There was a problem hiding this comment.
Yes kind of weird haha, but consistent with the original implementation ;)
I had failing slow integration tests for Sam on my end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was going crazy with tests failing on Sam2 after merging with main, turns out there's a typo in SAM after #39120
Cc @ArthurZucker