fix(date): improve caching accuracy #3887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CachedDate` gets updated every second, but the current logic doesn't take into account milliseconds - if the application starts at `12:00:00.600`, hyper will report `date: ...T120000` up until `12:00:01.599`, which is overzealous. We can sidestep this by subtracing the nanoseconds part (which includes milliseconds) from the time passed to `CachedDate::update()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CachedDategets updated every second, but the current logic doesn't take into account milliseconds and nanoseconds - if the application starts at12:00:00.600, hyper will reportdate: ...T120000up until12:00:01.600, which is overzealous.We can sidestep this by subtracting the nanoseconds part (which includes milliseconds) from the time passed to
CachedDate::update(), essentially roundingself.next_updateto the beginning of the next closest second.