Merge changes from next to master branch #2315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
requested changes
Jun 27, 2025
LucioFranco
reviewed
Jul 2, 2025
| [package.metadata.cargo_check_external_types] | ||
| allowed_external_types = [ | ||
| "tonic::*", | ||
| "futures_core::stream::Stream", |
There was a problem hiding this comment.
We should pull from tokio_stream instead
There was a problem hiding this comment.
@arjan-bal @dfawley @easwars if one of you can get to this simple fix that would be good, I am going to merge this anyways now.
There was a problem hiding this comment.
tokio_stream re-exports futures_core::Stream, so are these just equivalent?
There was a problem hiding this comment.
Yes, they are except that the tokio org controls the tokio_stream crate and I would rather depend on that than on the futures set of crates. (I have publish access for tokio_stream etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.