perf: improve startup time by deferring config defaults #2119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change wraps the function `_man_cmd_fn` which checks the system to find which man previewer is installed. This system check is expensive and does not need to be called until it is actually required. This reduces the startup time of fzf-lua. An example of the difference: Before: event time percent fzf-lua 41.34 42.38 fzf-lua.config 37.96 38.91 fzf-lua.defaults 37.57 38.51 After: event time percent fzf-lua 3.29 5.66 fzf-lua.config 0.98 1.69 fzf-lua.path 0.67 1.15 fzf-lua.defaults 0.53 0.91
|
Ty @EdenEast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change wraps the function
_man_cmd_fnwhich checks the system to find which man previewer is installed. This system check is expensive and does not need to be called until it is actually required. This reduces the startup time of fzf-lua. An example of the difference via vim-startuptime:Before:
After:
Relates: #970