Skip to content

Expose activate method #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2025
Merged

Conversation

dharmveer15512
Copy link
Contributor

Enhance Spreadsheet component with ref support and add related tests

  • Introduced SpreadsheetRef type to expose an activate method for cell activation.
  • Updated Spreadsheet component to support forwarding refs and added memoized methods.
  • Enhanced tests to cover new ref methods, ensuring they are stable and handle invalid points gracefully.
  • Added a new story for controlled activation demonstrating the use of the ref.

This update improves the usability of the Spreadsheet component by allowing parent components to programmatically activate cells.

Test case result.

image

- Introduced  type to expose an  method for cell activation.
- Updated  component to support forwarding refs and added memoized methods.
- Enhanced tests to cover new ref methods, ensuring they are stable and handle invalid points gracefully.
- Added a new story for controlled activation demonstrating the use of the ref.

This update improves the usability of the Spreadsheet component by allowing parent components to programmatically activate cells.
@iddan
Copy link
Owner

iddan commented Jan 21, 2025

Wow this is really cool! I don't have the capacity to fully test this at the very moment but I'll try to get to it as soon as possible

@dharmveer15512
Copy link
Contributor Author

Sure.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12856572900

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 82.227%

Totals Coverage Status
Change from base Build 12552465743: 0.06%
Covered Lines: 1149
Relevant Lines: 1324

💛 - Coveralls

@iddan iddan merged commit 7bce46c into iddan:master Mar 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants