Fix issue 77 #78
Merged
Fix issue 77 #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #77 Maximum pool size for Executors.newCachedThreadPool() is Integer.MAX_VALUE. This is not useful, when you want to decide, on how many threads a task should be distributed. Use the number of available processor as an upper limit in that case.
See #77 Fix problems when number of tasks is very high.
ctrueden
added a commit
to scijava/pom-scijava
that referenced
this pull request
Dec 3, 2018
This version fixes a bug (introduced in 0.11.0) in thread allocation, that broke things including the HessianMatrix.calculateMatrix method. See imglib/imglib2-algorithm#77 and imglib/imglib2-algorithm#78.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #77
Executors.newCachedThreadPool().getMaximumPoolSize() return Integer.MAX_VALUE.
This caused some problems (number overflow) trying to parallelize Gauss convolution.
This PR makes some changes that improve the code for parallelization when the number
of threads is very high.