Fix Derivative of Gauss3 Kernel #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an error, in one of the equations for calculating a determinant.
maarzt
force-pushed
the
smoothen-gauss3
branch
from
e38efd5 to
3f70a84
Compare
|
I think we should merge this? @tpietzsch @StephanPreibisch |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that under certain circumstances the derivative of a image blurred with
Gauss3might contain significant artifacts. These artifacts are caused by the truncation of the kernel, which results in a step at the end of the kernel. This "step" can be seen in a derivative of the image.The problem is known and solved in ImageJ1 GaussianBlur: https://github.com/imagej/imagej1/blob/4a98636b35bf1f75a25062d2793e3558cdcc6291/ij/plugin/filter/GaussianBlur.java#L515-L518
This PR applies the same solution (as known from IJ1) to Gauss3. Tests to measure the quality of the Gaussian blur and it's first and second derivative are added too.