String size refactor take 2 ext/standard last wave #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PHP-5.4: fix cve number
* PHP-5.5: fix cve number
Linux are now used. DTrace is part of Oracle Linux. See https://oss.oracle.com/projects/DTrace/ This patch does not change DTrace linking for non-Solaris/Linux platforms. For SystemTap users on Linux, this patch removes the compilation warning: Warning: Linking the shared library libphp5.la against the non-libtool objects Zend/zend_dtrace.d.o is not portable!
* PHP-5.4: With --enable-dtrace, the correct PIC/non-PIC .o files on Solaris and Linux are now used. DTrace is part of Oracle Linux. See https://oss.oracle.com/projects/DTrace/
* PHP-5.5: With --enable-dtrace, the correct PIC/non-PIC .o files on Solaris and Linux are now used. DTrace is part of Oracle Linux. See https://oss.oracle.com/projects/DTrace/
… PHP-5.4 * 'PHP-5.4' of https://git.php.net/repository/php-src: fix cve number
… PHP-5.5 * 'PHP-5.5' of https://git.php.net/repository/php-src: fix cve number
* 'master' of https://git.php.net/repository/php-src: fix cve number
* PHP-5.4: Update NEWS
* PHP-5.5: Update NEWS Update NEWS
* PHP-5.5: merge news for 5.5.2
* PHP-5.5: fix typo
… PHP-5.5 * 'PHP-5.5' of https://git.php.net/repository/php-src: fix typo merge news for 5.5.2
* 'master' of https://git.php.net/repository/php-src: fix typo merge news for 5.5.2
* 'PHP-5.5' of git.php.net:php-src: (30 commits) Fix duplicated 5.5.2 NEWS in my tree fix typo merge news for 5.5.2 Update NEWS Update NEWS With --enable-dtrace, the correct PIC/non-PIC .o files on Solaris and Linux are now used. DTrace is part of Oracle Linux. See https://oss.oracle.com/projects/DTrace/ fix cve number New news section Prepare news for PHP-5.5.2 Reduce compiler noise by removing unused variables and labels Fixed #65431 in zend_exception.c by Sixd Reduce (some) compile noise of 'unused variable' and 'may be used uninitialized' warnings. Skip test if SKIP_ONLINE_TESTS set Fix CVE-2013-4073 - handling of certs with null bytes Fix CVE-2013-4073 - handling of certs with null bytes Fixed #65431 (Discarded qualifiers from pointer target warnings when using --enable-dtrace) by Sixd removed unused vars fixed strndup usage in the pgsql ext use mysqlnd, some tests fail otherwise ensure notices are not ignored when tests need them ...
* 'master' of git.php.net:php-src: (22 commits) fix typo merge news for 5.5.2 Update NEWS Update NEWS With --enable-dtrace, the correct PIC/non-PIC .o files on Solaris and Linux are now used. DTrace is part of Oracle Linux. See https://oss.oracle.com/projects/DTrace/ fix cve number New news section Prepare news for PHP-5.5.2 Remove unused variable Reduce compiler noise by removing unused variables and labels Fixed #65431 in zend_exception.c by Sixd Reduce (some) compile noise of 'unused variable' and 'may be used uninitialized' warnings. Skip test if SKIP_ONLINE_TESTS set Fix to file uploads >2G with size overflow Fix CVE-2013-4073 - handling of certs with null bytes Fix CVE-2013-4073 - handling of certs with null bytes Fixed #65431 (Discarded qualifiers from pointer target warnings when using --enable-dtrace) by Sixd Fix unused variable warning in OCI8 2.0 removed unused vars fixed strndup usage in the pgsql ext ...
* PHP-5.5: code related typo fixes Fix duplicated 5.5.2 NEWS in my tree
* pull-request/405: Fixbug: phpize --clean will delete include/*.h
This fixes issues that were found during static analysis by cjones where failure was impossible to detect due to return type mangling (casting an int to a char, then comparing to an int).
* PHP-5.5: Fix return types of password API helper functions.
* PHP-5.4: Fix pointer sign warning showing up in EVERY build
* PHP-5.5: Fix pointer sign warning showing up in EVERY build
php-5.5/ext/session/session.c:836: warning: unused variable ‘struc’
php-5.5/ext/session/session.c:836: warning: unused variable ‘num_key’
php-5.5/ext/session/session.c:836: warning: unused variable ‘key_length’
php-5.5/ext/session/session.c:836: warning: unused variable ‘key’
php-5.5/ext/session/session.c:835: warning: unused variable ‘key_type’
php-5.5/ext/session/session.c:834: warning: unused variable ‘_ht’
php-5.5/ext/session/session.c:857: warning: unused variable ‘has_value’
php-5.5/ext/session/session.c:856: warning: unused variable ‘namelen’
php-5.5/ext/session/session.c:853: warning: unused variable ‘name’
php-5.5/ext/session/session.c:852: warning: unused variable ‘p’
php-5.5/ext/session/mod_user.c:191: warning: unused variable ‘ret’
* PHP-5.5: Reduce compilation noise during normal compilation: php-5.5/ext/session/session.c:836: warning: unused variable ‘struc’ php-5.5/ext/session/session.c:836: warning: unused variable ‘num_key’ php-5.5/ext/session/session.c:836: warning: unused variable ‘key_length’ php-5.5/ext/session/session.c:836: warning: unused variable ‘key’ php-5.5/ext/session/session.c:835: warning: unused variable ‘key_type’ php-5.5/ext/session/session.c:834: warning: unused variable ‘_ht’ php-5.5/ext/session/session.c:857: warning: unused variable ‘has_value’ php-5.5/ext/session/session.c:856: warning: unused variable ‘namelen’ php-5.5/ext/session/session.c:853: warning: unused variable ‘name’ php-5.5/ext/session/session.c:852: warning: unused variable ‘p’
… discards qualifiers from pointer target type"
* PHP-5.4: Suppress compliation warning "warning: passing argument 1 of ‘_efree’ discards qualifiers from pointer target type"
* PHP-5.5: Suppress compliation warning "warning: passing argument 1 of ‘_efree’ discards qualifiers from pointer target type"
… PHP-5.4 * 'PHP-5.4' of https://git.php.net/repository/php-src: Suppress compliation warning "warning: passing argument 1 of ‘_efree’ discards qualifiers from pointer target type"
… PHP-5.5 * 'PHP-5.5' of https://git.php.net/repository/php-src: Suppress compliation warning "warning: passing argument 1 of ‘_efree’ discards qualifiers from pointer target type"
* 'master' of https://git.php.net/repository/php-src: Suppress compliation warning "warning: passing argument 1 of ‘_efree’ discards qualifiers from pointer target type"
…sed [-Wunused-but-set-variable]"
…d [-Wunused-but-set-variable]"
* PHP-5.4: Suppress compiler warning "warning: variable ‘length’ set but not used [-Wunused-but-set-variable]" Suppress compiler warning "warning: variable ‘retcount’ set but not used [-Wunused-but-set-variable]"
* PHP-5.5: Suppress compiler warning "warning: variable ‘length’ set but not used [-Wunused-but-set-variable]" Suppress compiler warning "warning: variable ‘retcount’ set but not used [-Wunused-but-set-variable]"
…ize_refactor_take_2
…ling/php-src into string_size_refactor_take_2
ircmaxell
added a commit
that referenced
this pull request
Aug 22, 2013
String size refactor take 2 ext/standard last wave
ircmaxell
pushed a commit
that referenced
this pull request
Apr 18, 2014
krakjoe
added a commit
that referenced
this pull request
Apr 25, 2014
Refactor generator checks to occur in function declaration end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ext/standard should be solid for the current stage. It'll need to be revised at specific places when int64 comes, however as much as any other stuff will need the same. Also, the todays master is merged in.