String size refactor take 2 next wave #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code violated the strict aliasing restriction, because it dereferenced the same pointer as zval** once and as void** afterwards. Now both occurances dereference void** and cast to zval* in the former case.
…ON_ENTRY/RETURN cases
Turns out that you can't use implicit void pointer casts if intl is compiled.
Third try to make this work...
* PHP-5.4: Fixed other compiler warnings
* PHP-5.5: Fixed other compiler warnings
And that actually seems to be it, all tests pass so far. So lets see how it goes in the fture, too easy but seems to be done for now .
…‘_efree’ discards qualifiers from pointer target type"" This reverts commit f38bd22.
…‘_efree’ discards qualifiers from pointer target type"" This reverts commit f38bd22.
…‘_efree’ discards qualifiers from pointer target type"" This reverts commit f38bd22.
… discards qualifiers from pointer target type"
* PHP-5.4: Suppress compliation warning "warning: passing argument 1 of ‘_efree’ discards qualifiers from pointer target type" Revert "Suppress compliation warning "warning: passing argument 1 of ‘_efree’ discards qualifiers from pointer target type""
* PHP-5.5: Suppress compliation warning "warning: passing argument 1 of ‘_efree’ discards qualifiers from pointer target type" Revert "Suppress compliation warning "warning: passing argument 1 of ‘_efree’ discards qualifiers from pointer target type"" Revert "Suppress compliation warning "warning: passing argument 1 of ‘_efree’ discards qualifiers from pointer target type""
…ON_ENTRY/RETURN cases
Now only the flaw is pcrelib itself as it works with int for string length and offsets. Bigger stuff won't work anyway, but if there are some issue there are just a few places like pcre_exec() where we can explicitly cast to int.
* PHP-5.5: ensure the test doesn't fail because of tz warning
As things like if(0) will be removed by the compiler, no need to see that tons of warnings with static analyzer enabled.
* PHP-5.5: Suppress static analyzer warnings in specialized executor Update NEWS
…ize_refactor_take_2
won't work yet, just initial work to be done
ircmaxell
added a commit
that referenced
this pull request
Aug 27, 2013
String size refactor take 2 next wave
krakjoe
added a commit
that referenced
this pull request
Apr 25, 2014
Workaround for opcache clearing symbol table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patched the following
Fixed internal ext/pcre functions to work with zend_str_size and consequently the usage in SPL.Some other small fixes are there for CLI, datetime, etc. Regarding PCRE it uses int, so we should thing about submitting a patch or at least filing a bug to PCRE itself to fix that.
The ext/intl should be reviewed though as ICU works with int32_t for string sizes. Also it contains things like the stollen ascii substr implementation (from ext/standard). As of now it works, may be it can wait until we integrate int64.