Skip to content

Commit f365f75

Browse files
committed
Fix-478 incremental update, review fixes
Signed-off-by: Bala Raman <[email protected]>
1 parent 6def975 commit f365f75

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

dockerfile_functions.sh

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -480,9 +480,9 @@ EOI
480480
print_ubi_slim_package() {
481481
cat >> "$1" <<-EOI
482482
export PATH="${jhome}/bin:\$PATH"; \\
483-
dnf install -y binutils; \\
483+
dnf install -y binutils; \\
484484
/usr/local/bin/slim-java.sh ${jhome}; \\
485-
dnf remove -y binutils; \\
485+
dnf remove -y binutils; \\
486486
dnf clean all; \\
487487
EOI
488488
}
@@ -491,9 +491,9 @@ EOI
491491
print_ubi-minimal_slim_package() {
492492
cat >> "$1" <<-EOI
493493
export PATH="${jhome}/bin:\$PATH"; \\
494-
microdnf install -y binutils; \\
494+
microdnf install -y binutils; \\
495495
/usr/local/bin/slim-java.sh ${jhome}; \\
496-
microdnf remove -y binutils; \\
496+
microdnf remove -y binutils; \\
497497
microdnf clean all; \\
498498
EOI
499499
}
@@ -681,11 +681,12 @@ RUN set -eux; \\
681681
case "\${ARCH}" in \\
682682
EOI
683683
print_java_install_pre "${file}" "${pkg}" "${bld}" "${btype}" "${osfamily}" "${os}"
684-
if [ "${btype}" == "slim" && ${os} == "ubi"]; then
685-
print_ubi_slim_package "$1"
686-
fi
687-
if [ "${btype}" == "slim" && ${os} == "ubi-minimal"]; then
688-
print_ubi-minimal_slim_package "$1"
684+
if [ "${btype}" == "slim" ]; then
685+
if [ ${os} == "ubi" ]; then
686+
print_ubi_slim_package "$1"
687+
elif [ ${os} == "ubi-minimal"]; then
688+
print_ubi-minimal_slim_package "$1"
689+
fi
689690
fi
690691
print_java_install_post "$1"
691692
}

0 commit comments

Comments
 (0)