Add issues

.gitignore

@@ -1,3 +1,2 @@
 .DS_Store
-package-lock.json
 node_modules

.sonarcloud.properties

@@ -4,7 +4,7 @@ sonar.sources=dist
 #sonar.inclusions=
 
 # Path to tests
-sonar.tests=tests
+#sonar.tests=tests
 #sonar.test.exclusions=
 #sonar.test.inclusions=
 

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Migrate qunit tests to mocha
+
 ## [2.1.0] - 2019-02-09
 
 ### Added

develop.md

@@ -12,12 +12,12 @@ Install dependencies:
 
 Verify that all automated tests are passing:
 
-    TODO
+    npm test
 
-Open the unit tests:
+Optionally, open the unit tests in a browser:
 
-    open tests/vanilla.html
-    open tests/jquery.html
+    open test/vanilla.html
+    open test/jquery.html
 
 
 Importing from another new Stack Exchange site

dist/upvotejs/upvotejs.jquery.js

@@ -34,23 +34,18 @@
   const enabledClass = 'upvotejs-enabled';
 
   function init(dom, options) {
-    var total = 0;
-    var failed = 0;
-    var ret = dom.each(function() {
-      const jqdom = $(this);
-      methods.destroy(jqdom);
-
-      const id = jqdom.attr('id');
-      try {
-        total++;
+    const created = [];
+    try {
+      var ret = dom.each(function() {
+        const jqdom = $(this);
+        const id = jqdom.attr('id');
         const obj = Upvote.create(id, options);
         jqdom.data(namespace, obj);
-      } catch (e) {
-        failed++;
-      }
-    });
-    if (failed > 0) {
-      throw 'error: failed to create ' + failed + '/' + total + ' controllers';
+        created.push(jqdom);
+      });
+    } catch (e) {
+      created.forEach(obj => methods.destroy(obj));
+      throw e;
     }
     return ret;
   }

dist/upvotejs/upvotejs.vanilla.js

@@ -1,3 +1,5 @@
+// TODO
+// TODO
 /*
  * UpvoteJS - a Stack Exchange look-alike voting widget
  * ----------------------------------------------------
@@ -27,10 +29,16 @@
  *  Upvote.create('id', {count: 5, upvoted: true});
  *
  */
+    const a = 1;
+    if (a = a) {
+      console.log('foo');
+    }
+
+const UpvoteJS = function(document) {
+  "use strict";
 
-const Upvote = function() {
-  const upvoteClass = 'upvote';
   const enabledClass = 'upvotejs-enabled';
+  const upvoteClass = 'upvote';
   const upvoteOnClass = 'upvote-on';
   const downvoteClass = 'downvote';
   const downvoteOnClass = 'downvote-on';
@@ -135,7 +143,7 @@ const Upvote = function() {
     const create = id => {
       const dom = document.getElementById(id);
       if (dom === null) {
-        throw 'error: could not find element with ID ' + id + ' in the DOM';
+        throw 'error: element with ID "' + id + '" must exist in the DOM';
       }
 
       if (Utils.classes(dom).includes(enabledClass)) {
@@ -146,7 +154,7 @@ const Upvote = function() {
       const firstElementByClass = className => {
         const list = dom.getElementsByClassName(className);
         if (list === null) {
-          throw 'error: could not find element with class ' + className + ' within element with ID ' + id + ' in the DOM';
+          throw 'error: element with class "' + className + '" must exist within element with ID "' + id + '" in the DOM';
         }
         return list[0];
       };
@@ -274,7 +282,7 @@ const Upvote = function() {
     const callback = action => {
       const data = model.data();
       combinedParams.callback({
-        id: data.id,
+        id: id,
         action: action,
         newState: {
           count: data.count,
@@ -345,4 +353,35 @@ const Upvote = function() {
   return {
     create: create
   };
-}();
+};
+
+(function(global, factory) {
+  "use strict";
+
+  if (typeof module === "object" && typeof module.exports === "object") {
+    const create = () => {
+      if (global.document) {
+        return factory(global, true);
+      }
+      return w => {
+        if (!w.document) {
+          throw new Error("UpvoteJS requires a window with a document");
+        }
+        return factory(w);
+      };
+    };
+    module.exports = create();
+  } else {
+    factory(global);
+  }
+})(typeof window !== "undefined" ? window : this, function(window, noGlobal) {
+  const Upvote = UpvoteJS(window.document);
+  if (!noGlobal) {
+    window.Upvote = Upvote;
+  }
+    const a = 1;
+    if (a = a) {
+      console.log('foo');
+    }
+  return Upvote;
+});