feat: add support for mariadb datasource, #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tangyang9464 @imp2002 please review |
|
|
happenedIn
changed the title
…tants file for database product names
happenedIn
force-pushed
the
support-mariadb-datasource
branch
from
1688c0d to
49e2499
Compare
hsluoyz
requested changes
Dec 31, 2024
| @@ -0,0 +1,9 @@ | |||
| package org.casbin.constants; | |||
|
|
|||
| public enum AdapterConstants { | |||
| @@ -59,10 +60,10 @@ private void open() throws SQLException { | |||
| private void createDatabase() { | |||
| Session session = factory.openSession(); | |||
| Transaction tx = session.beginTransaction(); | |||
| if (this.databaseProductName.contains("MySQL")) { | |||
| if (this.databaseProductName.contains(AdapterConstants.MySQL.name()) || this.databaseProductName.contains(AdapterConstants.MariaDB.name())) { | |||
There was a problem hiding this comment.
Don't repeat this thing so many times. Make it simpler and smaller
There was a problem hiding this comment.
thanks, added a new PR that is simpler
|
Replaced by: #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #19 added unit test, added constants file for database product names