Skip to content

Compatible with Swift4 #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Compatible with Swift4 #235

wants to merge 3 commits into from

Conversation

didisouzacosta
Copy link

Changes for compatible with swift4.

@jonkykong
Copy link
Owner

Hi @didisouzacosta, is this the result of going through Xcode's upgrade swift process? The only code changes I see are adding @objc to some of the methods, which should not be necessary. Other than that, it should only be to silence Xcode's warnings about Swift version support by upgrading the supported version.

@seeker12
Copy link

@jonkykong - there appears to be a number cocoapod related version updates, as well as Xcode 9 @objc warning fixes.

@tudorpopa39
Copy link

@jonkykong - I would like to know when this changes will be merged to master, now when Swift4 and Xcode 9 is officially on

@Ethandf90
Copy link

please make Swift 4 support soon, thanks!

@RamblinWreck77
Copy link

Hello, I had to make these changes as well. Please consider merging this and releasing an update.

@jonkykong
Copy link
Owner

Closing in favor of #253.

@jonkykong jonkykong closed this Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants