Skip to content

Fixed circular reference in Xcode 11.4b1 #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed circular reference in Xcode 11.4b1 #598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Pod/Classes/SideMenuNavigationController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ internal protocol SideMenuNavigationControllerTransitionDelegate: class {
func sideMenuTransitionDidDismiss(menu: Menu)
}

public struct SideMenuSettings: SideMenuNavigationController.Model, InitializableStruct {
public struct SideMenuSettings: Model, InitializableStruct {
public var allowPushOfSameClassTwice: Bool = true
public var alwaysAnimate: Bool = true
public var animationOptions: UIView.AnimationOptions = .curveEaseInOut
Expand Down Expand Up @@ -105,12 +105,11 @@ public struct SideMenuSettings: SideMenuNavigationController.Model, Initializabl
}

internal typealias Menu = SideMenuNavigationController
internal typealias Model = MenuModel & PresentationModel & AnimationModel

@objcMembers
open class SideMenuNavigationController: UINavigationController {

internal typealias Model = MenuModel & PresentationModel & AnimationModel

private lazy var _leftSide = Protected(false) { [weak self] oldValue, newValue in
guard self?.isHidden != false else {
Print.warning(.property, arguments: .leftSide, required: true)
Expand Down Expand Up @@ -336,7 +335,7 @@ open class SideMenuNavigationController: UINavigationController {
}

// Interface
extension SideMenuNavigationController: SideMenuNavigationController.Model {
extension SideMenuNavigationController: Model {

@IBInspectable open var allowPushOfSameClassTwice: Bool {
get { return settings.allowPushOfSameClassTwice }
Expand Down