Skip to content

Commit 00d4132

Browse files
Elle Meredithelle
authored andcommitted
Add a layout for a landing page
which means we added a branch for the `layout_by_path` again but we removed multiple checks from the layout views
1 parent da6e937 commit 00d4132

File tree

3 files changed

+31
-3
lines changed

3 files changed

+31
-3
lines changed

app/controllers/pages_controller.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,12 @@ def beta?
3131
def landing_page?
3232
@page && @page.landing_page?
3333
end
34-
helper_method :landing_page?
3534

3635
def layout_by_path
3736
if request.path.starts_with? "/docs/apis/graphql"
3837
"graphql"
38+
elsif landing_page?
39+
"landing_page"
3940
else
4041
"application"
4142
end

app/views/layouts/application.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@
88
<main id="main" role="main">
99
<div class="Docs__page-container StandardWhiteContentPage">
1010
<div class="Docs__page-container__inner PageContainer">
11-
<div class="Docs__article<%= landing_page? ? ' Docs__article--is-landing-page' : '' %>">
11+
<div class="Docs__article">
1212
<div class="column1">
1313
<%= render "notification" %>
1414
<div class="TextContent">
1515
<%= yield %>
1616
</div>
17-
<%= render "footer", :embed_emojicom => !landing_page? %>
17+
<%= render "footer", :embed_emojicom => true %>
1818
</div>
1919
<div class="column2"></div>
2020
</div>
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
<!DOCTYPE html>
2+
<html lang='en'>
3+
<head>
4+
<%= render "head" %>
5+
</head>
6+
<body <%= beta? ? 'class=beta' : ''-%>>
7+
<%= render "site_header" %>
8+
<main id="main" role="main">
9+
<div class="Docs__page-container StandardWhiteContentPage">
10+
<div class="Docs__page-container__inner PageContainer">
11+
<div class="Docs__article Docs__article--is-landing-page">
12+
<div class="column1">
13+
<%= render "notification" %>
14+
<div class="TextContent">
15+
<%= yield %>
16+
</div>
17+
<%= render "footer", :embed_emojicom => false %>
18+
</div>
19+
<div class="column2"></div>
20+
</div>
21+
</div>
22+
</div>
23+
</main>
24+
<%= render "algolia" %>
25+
<%= javascript_include_tag "nav", nonce: true %>
26+
</body>
27+
</html>

0 commit comments

Comments
 (0)