Skip to content

Translations #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Translations #1

wants to merge 34 commits into from

Conversation

Pthomas2
Copy link
Contributor

No description provided.

jschanker
jschanker requested changes May 29, 2020
View reviewed changes
Pthomas2
Pthomas2 commented May 29, 2020
View reviewed changes
Copy link
Contributor Author

@Pthomas2 Pthomas2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I fixed them all

@Pthomas2 Pthomas2 closed this May 29, 2020
@jschanker jschanker reopened this May 29, 2020
jschanker
jschanker requested changes May 29, 2020
View reviewed changes
Copy link
Owner

@jschanker jschanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, don't close the pull request before it's merged.

@jschanker
Copy link
Owner

Also, instead of CONFIRM_DELETE_REPLACE, use CONFIRM_CONVERT_TEXT_TO_BLOCKS because (a) CONFIRM_DELETE_REPLACE would still be applicable for loading the blocks from the XML and (b) this connects it to the button constant BUTTON_CONVERT_TEXT_TO_BLOCKS

jschanker
jschanker requested changes May 30, 2020
View reviewed changes
Pthomas2 added 2 commits June 1, 2020 11:11
@Pthomas2
Added back sentence endings
f26bf6b
@Pthomas2
textual changes
32ba82a 
reverted original text for button convert to JS and changed name for confirm delete replace.
@Pthomas2 Pthomas2 mentioned this pull request Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschanker jschanker jschanker requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pthomas2 @jschanker