Update Logo to X in README for Consistency #56
Conversation
|
@adityajha2005 Thanks for PR but as its seen the new logo of X won't look good when user is using GitHub in dark mode. Can you find a solution for this ? |
@DhairyaMajmudar Alternatively, I can use an image with an opaque background like this |
|
Awsm! Go with this |
|
mb, i'll just open another pr once it's done @DhairyaMajmudar |
Update in this PR only |
GitHub README doesn’t support dynamic theme switching, so the X logo may not be visible properly in dark mode. To fix this, we’ll need an SVG with an opaque background. Let me know what you think! |
| @@ -123,7 +123,7 @@ Explore the website and see how you can contribute to this evolving space. Wheth | |||
| <img align="center" src="https://img.icons8.com/color/48/null/slack-new.png" alt="JSON Schema Slack" height="30" width="40" /> | |||
| </a> | |||
| <a href="https://twitter.com/jsonschema" target="blank" style="margin-right: 5px;"> | |||
| <img align="center" src="https://raw.githubusercontent.com/rahuldkjain/github-profile-readme-generator/master/src/images/icons/Social/twitter.svg" alt="JSON Schema Twitter" height="30" width="40" /> | |||
| <img align="center" src="./static/images/logos/x-social-media-logo-icon.svg" alt="JSON Schema X" height="30" width="40" /> | |||
There was a problem hiding this comment.
I think we will need the full url here. Remember this is the readme of the repo, not the website.
What kind of change does this PR introduce?
Enhancement : Updated logo of Twitter to X because of the rebranding
Issue Number:
Screenshots/videos:
Before :
After :
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?