Skip to content

Update code of conduct in CONTRIBUTING.md #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

handrews
Copy link
Contributor

I copied this file over to the referencing spec and was informed it was out of date, so here's a backport of the update.

@handrews handrews marked this pull request as ready for review October 24, 2022 17:43
CONTRIBUTING.md Outdated
@@ -46,7 +46,7 @@ As an informative document, bugs in the meta-schema may be fixed in place to ali

## Conduct

All official channels including the mailing list, GitHub organization, and Freenode channel, follow the IETF Guidelines for Conduct as specified in [RFC7154](https://tools.ietf.org/html/rfc7154).
All official channels including the mailing list, GitHub organization, Slack server, and Freenode channel, follow our [Code of Conduct](https://github.com/json-schema-org/.github/blob/main/CODE_OF_CONDUCT.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have a Freenode channel? I assume we don't have an IRC channel at all at this point and if we did it's probably on Libera (but I haven't checked in, maybe I should)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple of users in the Libera channel looks like, including @karenetheridge. (I don't have access to Freenode anymore nor do I think anyone else does, they password reset everyone during the hostile takeover or something right?)

TL;DR maybe it's easy to avoid all my comments by changing this to say IRC channels and remove the reference to Freenode.

Other than that, lgtm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Julian thanks, I changed it to "IRC channels".

Copy link
Member

@karenetheridge karenetheridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a "resources" section in our docs somewhere, it would be good to explicitly mention the libera irc channel (although I'd want more people connected to it, ideally :) )

@handrews
Copy link
Contributor Author

@karenetheridge I think I'll leave it to those who understand the state of the IRC stuff to update that. For now I'd like to just get the CoC link fixed. I'd be happy to quickly review and approve an IRC PR afterwards, though.

@gregsdennis
Copy link
Member

Merging as it's been approved for three weeks with no further activity.

@gregsdennis gregsdennis merged commit d292103 into json-schema-org:main Nov 20, 2022
@handrews handrews deleted the coc-contrib branch January 18, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants