Skip to content

Add all changes since last release to Change Log #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

handrews
Copy link
Contributor

@handrews handrews commented Dec 7, 2022

As promised in Monday's call, here is the change log i had researched covering all changes to date (plus PR #1359 which was agreed to in principle on the call as well).

@handrews handrews added this to the draft-next milestone Dec 7, 2022
@handrews handrews changed the title Add all changse since last release to Change Log Add all changes since last release to Change Log Dec 7, 2022
Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's impressively thorough! I don't think clarifications need a change log entry. I'd just include things that effect behavior.

<t>Consolidate and clarify the syntax and rationale for plain-name fragments</t>
<t>"$id" MUST be an absolute-IRI, without any fragment, even an empty one</t>
<t>Note that an empty string "$id" results in duplicate IRIs for different schemas</t>
<t>Define empty schemas as empty (no longer allowing unrecognized keywords</t>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<t>Define empty schemas as empty (no longer allowing unrecognized keywords</t>
<t>Define empty schemas as empty (no longer allowing unrecognized keywords)</t>

@Julian
Copy link
Member

Julian commented Dec 12, 2022

That's impressively thorough! I don't think clarifications need a change log entry. I'd just include things that effect behavior.

I agree though another riff on perhaps the same underlying suggestion is attempting to sort the list by some imprecise notion of "likelihood someone cares to read about it", which should be doable. E.g. contains changes are probably top of the list, and all the clarifying stuff likely falls near the bottom, if it isn't in fact cut out entirely.

@gregsdennis
Copy link
Member

Replaced by ☝️

gregsdennis added a commit that referenced this pull request Aug 28, 2023
gregsdennis added a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants