Skip to content

Remove some superfluous format="counter" attributes #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

awwright
Copy link
Member

@awwright awwright commented Dec 8, 2022

This shouldn't cause any changes except that "Section" or "Appendix" text is now included as part of the link.

@handrews I think you wrote all of these cases, can you double check?

Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the one stray extra "section", this looks good. I copied it locally and rendered it and the HTML output looks fine to me with these changes.

@@ -439,8 +438,7 @@
<t>
The root schema is the schema that comprises the entire JSON document
in question. The root schema is always a schema resource, where the
IRI is determined as described in section
<xref target="initial-base" format="counter"></xref>.
IRI is determined as described in section <xref target="initial-base"></xref>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left behind an extra "section" on this one.

@awwright awwright merged commit d29e9c4 into json-schema-org:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants