Skip to content

Bump certifi from 2022.6.15 to 2022.12.7 #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 9, 2022

Bumps certifi from 2022.6.15 to 2022.12.7.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@awwright
Copy link
Member

Is this PR useful for anything?

@dependabot rebase

Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.6.15 to 2022.12.7.
- [Release notes](https://github.com/certifi/python-certifi/releases)
- [Commits](certifi/python-certifi@2022.06.15...2022.12.07)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/certifi-2022.12.7 branch from 08cd614 to 9a0ba01 Compare March 27, 2023 09:36
@gregsdennis
Copy link
Member

@awwright it's updating a generated file. Maybe the better fix would be to update how it's being generated. Do you know if that just means running a build, or do we need to update pip? I don't know.

@Julian do you know?

@Julian
Copy link
Member

Julian commented Apr 4, 2023

Updating it fully would be running pip-compile -U requirements.in which is likely not a bad idea but also not a bad one to merge this immediately since it sounds like it fixes a vulnerability in the old version and there's no harm in merging essentially.

@gregsdennis gregsdennis merged commit d4306a9 into main Apr 4, 2023
@gregsdennis gregsdennis deleted the dependabot/pip/certifi-2022.12.7 branch April 4, 2023 22:34
@gregsdennis
Copy link
Member

What does fully updating entail? Do we just run that command locally and create a new PR?

@Julian
Copy link
Member

Julian commented Apr 4, 2023

Exactly yep. pip-compile you'll first need to install via e.g. pipx install pip-tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants