Skip to content

add minimum open time action for PRs #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 28, 2023
Merged

Conversation

gregsdennis
Copy link
Member

@gregsdennis gregsdennis commented Mar 13, 2023

Currently, this needs to be manually re-run. It'll run automatically on new commits, though.

  • I'm looking into running scheduled actions only on PRs. We don't want this running if it's not targeting a PR.

@gregsdennis
Copy link
Member Author

gregsdennis commented Mar 13, 2023

image

Could use a better name...

image

It works, though.

@gregsdennis
Copy link
Member Author

To update the minimum open time check, click on "Details" in the checks panel, and then choose "Re-run all jobs."
image

@gregsdennis

This comment was marked as resolved.

@gregsdennis
Copy link
Member Author

I hate yaml.

but it works.

finally.

@gregsdennis
Copy link
Member Author

Doesn't look like it's running on the schedule. Asking for clarification... (link above)

@gregsdennis
Copy link
Member Author

Okay looks like the schedule isn't going to run until this is merged. In the meantime, I'll rerun this job manually.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gregsdennis gregsdennis merged commit 2095bd3 into main Mar 28, 2023
@gregsdennis gregsdennis deleted the gregsdennis/minimum-open-time branch March 28, 2023 05:03
@awwright
Copy link
Member

@gregsdennis I'm kind of on the fence about this but I'm willing to try it out... but do you mind if I at least squash the commits here?

@gregsdennis
Copy link
Member Author

This is already merged to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants