Skip to content

Create ADR for SVA support #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Create ADR for SVA support #1394

merged 3 commits into from
Apr 5, 2023

Conversation

gregsdennis
Copy link
Member

@gregsdennis gregsdennis commented Apr 4, 2023

Related to https://github.com/orgs/json-schema-org/discussions/329

(This is my first ADR. Please be gentle. 😆)

Copy link
Contributor

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a typo: good for bad.

Co-authored-by: Mike Ralphson <[email protected]>
Co-authored-by: Jason Desrosiers <[email protected]>
Copy link
Contributor

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregsdennis gregsdennis merged commit 70af7dc into main Apr 5, 2023
@gregsdennis gregsdennis deleted the gregsdennis/adr-sva-prefix branch September 20, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants