Skip to content

remove 'mathematical integers' section #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2023
Merged

remove 'mathematical integers' section #1437

merged 1 commit into from
Sep 25, 2023

Conversation

gregsdennis
Copy link
Member

Resolves #898

After wordsmithing something that sounded approximately right, I found Instance Equality, which pretty much clears up any debate in my mind.

@gregsdennis gregsdennis marked this pull request as ready for review September 8, 2023 05:45
Relequestual
Relequestual approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per #898 (comment)
I agree, I don't think JSON encoding is within scope of the JSON Schema spec.

@TomWright
Copy link

TomWright commented Sep 25, 2023 •
edited
Loading

PR can be merged after Fri Sep 22 2023 05:45:26 GMT+0000 (Coordinated Universal Time)

It has now passed this date - any chance we can get this merged? It's causing me some problems.

I realised after the fact this was just a doc update. Apologies for the confusion

@gregsdennis
Copy link
Member Author

gregsdennis commented Sep 25, 2023 •
edited
Loading

Merging the PR isn't going to help in the near term any. This is merging into an unpublished document.

If you like, come join us in slack or start a discussion in the community repo and we can help you with out your problem.

I'll review and merge in the morning.

@gregsdennis gregsdennis merged commit 50893ed into main Sep 25, 2023
@gregsdennis gregsdennis deleted the gregsdennis/integers branch September 25, 2023 20:27
@jdesrosiers
Copy link
Member

I just noticed when building the spec to review another change that removing this section caused a couple broken links.

> @json-schema-org/[email protected] build-core
> node build/build.js < jsonschema-core.md > jsonschema-core.html

2757:1-2757:17 warning Link to unknown heading: `integers` missing-heading remark-validate-links
2778:1-2778:17 warning Link to unknown heading: `integers` missing-heading remark-validate-links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julian Julian Julian approved these changes

@jdesrosiers jdesrosiers jdesrosiers approved these changes

@Relequestual Relequestual Relequestual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integers need further clarification
5 participants
@gregsdennis @TomWright @jdesrosiers @Julian @Relequestual